Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-29619] Use rhc_not_configured to comply with OpenAPI spec #309

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

tahmidefaz
Copy link
Member

What?

RHCLOUD-29619

Playbook Dispatcher's high level API route's /internal/v2/connection_status endpoint is sending out invalid value for the status key.

The OpenAPI spec mentions that the "status" field under this endpoint is an enum with the following fields: connected, disconnected and rhc_not_configured.

However, in reality, Playbook Dispatcher is sending out no_rhc instead of rhc_not_configured.

Why?

🐛

How?

Describe how the change is implemented. Any noteable new libaries, APIs, or features.

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@tahmidefaz tahmidefaz requested a review from dehort November 29, 2023 17:12
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tahmidefaz tahmidefaz merged commit c33ae6e into RedHatInsights:master Nov 30, 2023
5 of 6 checks passed
@tahmidefaz tahmidefaz deleted the use-rhc_not_configured branch November 30, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants