Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources returns a 400 if the equal is url encoded #325

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Sources returns a 400 if the equal is url encoded #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/api/connectors/sources/impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,12 @@ func NewSourcesClientWithHttpRequestDoer(cfg *viper.Viper, doer HttpRequestDoer)
originalUrl := req.URL.String()
if strings.Contains(originalUrl, "filter=filter%5B") {
// Remove the extra filter parameter name
correctedUrl := strings.Replace(req.URL.String(), "filter=", "", -1)
urlWithExtraFilterRemoved := strings.Replace(req.URL.String(), "filter=", "", -1)

newUrl, err := url.Parse(correctedUrl)
// Convert the url encoded "=" to unencoded "=" for...otherwise sources returns a 400
urlWithEqualUnencoded := strings.Replace(urlWithExtraFilterRemoved, "%3D", "=", -1)

newUrl, err := url.Parse(urlWithEqualUnencoded)
if err != nil {
return err
}
Expand Down
Loading