Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to the playbook-run label #336

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

tahmidefaz
Copy link
Member

What?

BIG 🤞

Why?

Consider what business or engineering goal does this PR achieves.

How?

Describe how the change is implemented. Any noteable new libaries, APIs, or features.

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@tahmidefaz tahmidefaz requested a review from dehort February 7, 2024 19:12
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nit picky of me...I apologize, but would you mind changing the name of the index to more closely match the name of the existing indexes?

Here is a list of the existing indexes:

migrations/002_add-indexes.up.sql:CREATE INDEX runs_account_index ON runs (account);
migrations/002_add-indexes.up.sql:CREATE INDEX runs_labels_index ON runs USING GIN (labels JSONB_PATH_OPS);
migrations/009_add-org-id-index.up.sql:CREATE INDEX runs_org_id_index ON runs (org_id);

I am sorry!! :)

@tahmidefaz
Copy link
Member Author

This is really nit picky of me...I apologize, but would you mind changing the name of the index to more closely match the name of the existing indexes?

Here is a list of the existing indexes:

migrations/002_add-indexes.up.sql:CREATE INDEX runs_account_index ON runs (account);
migrations/002_add-indexes.up.sql:CREATE INDEX runs_labels_index ON runs USING GIN (labels JSONB_PATH_OPS);
migrations/009_add-org-id-index.up.sql:CREATE INDEX runs_org_id_index ON runs (org_id);

I am sorry!! :)

No problem, done! 🙂

@tahmidefaz tahmidefaz requested a review from dehort February 7, 2024 19:47
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tahmidefaz tahmidefaz merged commit ea8fe03 into RedHatInsights:master Feb 7, 2024
12 of 14 checks passed
@tahmidefaz tahmidefaz deleted the add-labels-index branch February 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants