Check for nil pointer in the sources client

[dehort]

What?

Its possible that the generated sources client can return a nil error and a nil pointer to the data. When this happens, the code attempts to dereferrence the nil pointer...which causes a panic. The web framework handles the panic and returns a 500 error.

RHCLOUD-31105

Why?

Consider what business or engineering goal does this PR achieves.

How?

Added more checks for nil pointers.

Testing

More tests were added to the sources client.

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

[justinorringer]

Looking good!

[tahmidefaz]

lgtm!

[dehort]

/retest