Ansible host

[justinorringer]

What?

Explain what the change is linking any relevant JIRAs or Issues.

Why?

Consider what business or engineering goal does this PR achieves.

How?

Adding ansible_host field from inventory

Testing

Updating the inventory unit tests.

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

[dehort]

Looking good. I left a note about how to fix the failing tests. You can see the test output here.

Your current set of changes add the AnsibleHost field to the inventory data. So that is step 1. Next we need to make sure that the AnsibleHost data gets returned back to the caller. I think we need to modify the RecipientWithConnectionInfo struct (regen the api code??) and then modify the formatConnectionResponse() function to add the AnsibleHost data to the instance of RecipientWithConnectionInfo.

This is kinda complicated. 😀 Let me know if that doesn't make sense.

[justinorringer]

Closing to change it again as we talked about https://issues.redhat.com/browse/RHCLOUD-30604?focusedId=24275850&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24275850