Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-29056 Upgrade debezium to 2.5 #356

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

josejulio
Copy link
Member

What?

Debezium 1.9 is no longer supported, upgrading to the latest release.

Why?

Preventing any future issue due to new libraries.

How?

Updating to Debezium 2.5 following their breaking changes from version 2

Testing

Not yet

Anything Else?

--

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@josejulio
Copy link
Member Author

/retest

1 similar comment
@dehort
Copy link
Contributor

dehort commented Mar 26, 2024

/retest

@josejulio josejulio marked this pull request as ready for review March 26, 2024 18:25
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment on lines 90 to 92
db:
image: quay.io/debezium/postgres:12
image: quay.io/debezium/postgres:14
restart: always
Copy link
Member

@tahmidefaz tahmidefaz Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, in PROD, I think we are using Postgres:12. Not sure if that will cause an issue with this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert back to '12' and let the tests run with it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried locally and still works fine.

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🤞

docker-compose.yml Outdated Show resolved Hide resolved
@josejulio josejulio merged commit c710f42 into RedHatInsights:master Mar 27, 2024
12 of 14 checks passed
@josejulio josejulio deleted the RHCLOUD-29056 branch March 27, 2024 14:05
josejulio added a commit to josejulio/playbook-dispatcher that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants