-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-29056 Upgrade debezium to 2.5 #356
Conversation
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
docker-compose.yml
Outdated
db: | ||
image: quay.io/debezium/postgres:12 | ||
image: quay.io/debezium/postgres:14 | ||
restart: always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, in PROD
, I think we are using Postgres:12
. Not sure if that will cause an issue with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert back to '12' and let the tests run with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried locally and still works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🤞
This reverts commit c710f42.
What?
Debezium 1.9 is no longer supported, upgrading to the latest release.
Why?
Preventing any future issue due to new libraries.
How?
Updating to Debezium 2.5 following their breaking changes from version 2
Testing
Not yet
Anything Else?
--
Secure Coding Practices Checklist Link
Secure Coding Checklist