Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use topic.heartbeat.prefix instead of the old heartbeat.topics.prefix #359

Merged

Conversation

josejulio
Copy link
Member

@josejulio josejulio commented Mar 28, 2024

What?

Should fix some errors we saw on stage where it complains about
a topic.

Turns out we were using the wrong configuration value and the
wrong topic.

Why?

We saw errors in stage logs (Thanks @tahmidefaz !)

2024-03-27 19:34:14,474 WARN [playbook-dispatcher-event-interface|task-0] [Producer clientId=connector-producer-playbook-dispatcher-event-interface-0] Error while fetching metadata with correlation id 184593 : {__debezium-heartbeat.playbook-dispatcher=UNKNOWN_TOPIC_OR_PARTITION} (org.apache.kafka.clients.NetworkClient) [kafka-producer-network-thread | connector-producer-playbook-dispatcher-event-interface-0]

How?

Compared the docs about 1.9 vs 2.5 version

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Should fix some errors we saw on stage where it complains about
 a topic.

Turns out we were using the wrong configuration value and the
 wrong topic.
Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🤞

@josejulio josejulio merged commit 20e8d1d into RedHatInsights:master Mar 28, 2024
12 of 14 checks passed
@josejulio josejulio deleted the use-topic.heartbeat.prefix branch March 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants