Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple attempt. Just start truncating after a fixed number of lines #386

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Simple attempt. Just start truncating after a fixed number of lines #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c460f5
Simple attempt. Just start truncating after a fixed number of lines
dehort Sep 6, 2024
b2ac4ca
Used a string for testing. Replaced string with correct constant
dehort Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 13 additions & 45 deletions internal/validator/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,18 +165,17 @@ func (this *handler) validateContent(ctx context.Context, requestType string, da

log := utils.GetLogFromContext(ctx)

maxMessageSize := 1 * 1024 * 1024

// FIXME: make this configurable
truncateData := len(data) >= 1*1024*1024
truncateData := len(data) >= maxMessageSize
if truncateData {
log.Debug("Payload too big. Truncating payload.")
}

eventTypeCount := make(map[string]int)
hostRunningPlaybook := make(map[string]int)

lines := strings.Split(string(data), "\n")

for _, line := range lines {
for i, line := range lines {
if len(strings.TrimSpace(line)) == 0 {
continue
}
Expand All @@ -192,59 +191,28 @@ func (this *handler) validateContent(ctx context.Context, requestType string, da
return nil, err
}

var storeEvent bool = true

if truncateData {

storeEvent = false

if validatedEvent.Type == "playbook_run_completed" || validatedEvent.Type == "playbook_run_finished" {
storeEvent = true
log.Debug("storing run complete/finished for host " /*, *validatedEvent.Host*/)
}

if validatedEvent.Type == "playbook_run_update" {

if validatedEvent.Host != nil {
if _, ok := hostRunningPlaybook[*validatedEvent.Host]; !ok {
storeEvent = true
log.Debugf("storing run update for host %s", *validatedEvent.Host)
}

hostRunningPlaybook[*validatedEvent.Host]++
}
if i > 500 && truncateData {
if validatedEvent.Console != nil || *validatedEvent.Console != "" {
var truncated string = "Truncated..."
validatedEvent.Console = &truncated
}
}

if storeEvent {
log.Debugf("storing event %s ", validatedEvent.Type)
events.PlaybookSat = append(events.PlaybookSat, *validatedEvent)
}
events.PlaybookSat = append(events.PlaybookSat, *validatedEvent)

} else {
validatedEvent, err := validateRunResponseWithSchema(ctx, this.schemas[0], line)
if err != nil {
return nil, err
}

var storeEvent bool = true

if truncateData {
storeEvent = false

// FIXME: hardcoded :(
if validatedEvent.Event == "executor_on_start" || validatedEvent.Event == "playbook_on_stats" || validatedEvent.Event == "runner_on_failed" || validatedEvent.Event == "executor_on_failed" {
eventTypeCount[validatedEvent.Event]++
storeEvent = eventTypeCount[validatedEvent.Event] <= 1
}
if i > 500 && i < len(lines)-2 && truncateData {
var truncated string = "Truncated..."
validatedEvent.Stdout = &truncated
}

if storeEvent {
log.Debugf("storing event %s", validatedEvent.Event)
events.Playbook = append(events.Playbook, *validatedEvent)
}
events.Playbook = append(events.Playbook, *validatedEvent)
}

}

if len(events.PlaybookSat) == 0 && len(events.Playbook) == 0 {
Expand Down
Loading