RHCLOUD-34086 Configure CPU and Memory requests as variables #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fynardo
force-pushed
the
rhcloud-34086/adr-46-config
branch
from
b457b93 to
eec1daf
Compare
gwenneg
reviewed
Oct 17, 2024
deploy/clowdapp.yaml
Outdated
| @@ -314,8 +314,12 @@ parameters: | |||
| value: INFO | |||
| - name: CPU_LIMIT | |||
| value: 500m | |||
| - name: CPU_REQUEST | |||
There was a problem hiding this comment.
What if we need to increase the CPU or memory one of component without changing the others? Should we have more parameters?
gwenneg
reviewed
Oct 17, 2024
deploy/connect.yaml
Outdated
Comment on lines
46
to
53
| - name: EVENT_CONSUMER_CPU_REQUESTS | ||
| value: 100m | ||
| - name: EVENT_CONSUMER_CPU_LIMITS | ||
| value: 200m | ||
| - name: EVENT_CONSUMER_MEMORY_REQUESTS | ||
| value: 128Mi | ||
| - name: EVENT_CONSUMER_MEMORY_LIMITS | ||
| value: 256Mi |
There was a problem hiding this comment.
Nitpick: keys could be singular instead of plural.
There was a problem hiding this comment.
Yes, lets be consistent in naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use vars to define CPU and Memory requests instead of hard-coded values
Why?
So we can configure CPU and Memory usage at deployment depending on env