Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQL parse error on PG16 #316

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix SQL parse error on PG16 #316

merged 1 commit into from
Sep 24, 2024

Conversation

dkuc
Copy link
Contributor

@dkuc dkuc commented Sep 23, 2024 •
edited by rexwhite
Loading

RHINENG-12798: Postgres 16 SQL parsing is a little more strict than postgres 14. A space is needed between the ? and the AND.

@dkuc dkuc requested a review from rexwhite as a code owner September 23, 2024 18:05
rexwhite
rexwhite approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@rexwhite rexwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh... good catch!

@vkrizan vkrizan merged commit b05ff9c into RedHatInsights:master Sep 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexwhite rexwhite rexwhite approved these changes

@marleystipich2 marleystipich2 Awaiting requested review from marleystipich2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkuc @rexwhite @vkrizan