SWATCH-3151: skip setting credential provider when using moto #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflahert
added
QE
Sgitario
requested changes
Jan 14, 2025
There was a problem hiding this comment.
We're opening a dangerous door here that allow users to submit usages to other servers using these credentials. Plus, we're losing the ability to test the credentials matching in the iqe tests.
Instead, we should configure moto to only allow requests for the expected aws seller account IDs credentials.
|
@Sgitario good point thanks! I'll fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: SWATCH-3151
Description
Skip setting aws credentials when moto is being used.