Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWATCH-3141: Configure swatch-billable-usage to skip bad messages #4108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SWATCH-3141: Configure swatch-billable-usage to skip bad messages #4108

wants to merge 1 commit into from
+1 −0

Conversation

wottop
Copy link
Contributor

@wottop wottop commented Jan 14, 2025 •
edited
Loading

Jira issue: SWATCH-3141

Description

Testing

IQE Test MR:
IQE MR

Setup

  1. I used an ephemeral instance and the local IQE proxy

Steps

  1. Run the tests in the IQE MR

Verification

  1. Tests pass
  2. Observe the swatch-billable-usage-service pod for a few minutes to confirm that it does not restart. You will also see the bad and good messages in the logs for that pod.

@wottop wottop marked this pull request as draft January 14, 2025 21:42
@wottop wottop force-pushed the wottop/SWATCH-3141 branch from 56df278 to 725957f Compare January 15, 2025 18:54
@wottop wottop changed the title SWATCH-3141: SWATCH-3141: Configure swatch-billable-usage to skip bad messages Jan 15, 2025
@wottop wottop marked this pull request as ready for review January 16, 2025 20:49
@wottop wottop added QE Pull request should be approved by QE before merge Dev Pull requests that need developer review labels Jan 16, 2025
@Sgitario Sgitario added Dev/approved Pull requests that have been approved by all assigned developers and removed Dev Pull requests that need developer review labels Jan 20, 2025
@Sgitario Sgitario self-assigned this Jan 20, 2025
@TrayvonMcKnight TrayvonMcKnight self-requested a review January 22, 2025 14:29
@TrayvonMcKnight TrayvonMcKnight self-assigned this Jan 22, 2025
@wottop
Copy link
Contributor Author

wottop commented Jan 22, 2025

/retest

@TrayvonMcKnight TrayvonMcKnight added QE/approved Pull requests that have been approved by all assigned QEs and removed QE Pull request should be approved by QE before merge labels Jan 24, 2025
@Sgitario
Copy link
Contributor

/retest

Sgitario
Sgitario requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing my approval because the new tests added are failing using these changes (I guess these tests need some changes)

@Sgitario Sgitario added needs-update Pull requests that need to be updated to address issues found by dev or QE reviewers and removed Dev/approved Pull requests that have been approved by all assigned developers labels Jan 28, 2025
@wottop wottop force-pushed the wottop/SWATCH-3141 branch from 0ab3c48 to d7f49d7 Compare January 28, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario requested changes

@TrayvonMcKnight TrayvonMcKnight TrayvonMcKnight approved these changes

Assignees

@Sgitario Sgitario

@TrayvonMcKnight TrayvonMcKnight

Labels
needs-update Pull requests that need to be updated to address issues found by dev or QE reviewers QE/approved Pull requests that have been approved by all assigned QEs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wottop @Sgitario @TrayvonMcKnight