RHCLOUD-3652 | refactor: reduce noise in the logs #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Bad Request", "Not Found" and "Unauthorized" errors were logging the exact same message that was being returned to the callers, without any context. Therefore, they feel more like "access logs" than actual error logs that we should be warned about. And "access logs", if we had them here, should just log "info" statements with all sorts of data about the caller, plus the response that was given to them. RHCLOUD-36529
MikelAlejoBR
force-pushed
the
RHCLOUD-36529-reduce-noise-logs
branch
from
47a4cab to
03488aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Bad Request", "Not Found" and "Unauthorized" errors were logging the exact same message that was being returned to the callers, without any context. Therefore, they feel more like "access logs" than actual error logs that we should be warned about. And "access logs", if we had them here, should just log "info" statements with all sorts of data about the caller, plus the response that was given to them.
Jira ticket
[RHCLOUD-36529]