Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not used Kafka topic platform.topological-inventory.operations… #738

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

dscervantes
Copy link
Contributor

Remove not used Kafka topic platform.topological-inventory.operation-satellite

RHCLOUD-31321

Copy link
Member

@MikelAlejoBR MikelAlejoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But I would actually like to request you to please remove the following things too:

  • The entire EndpointAvailabilityCheck method and the subsequent publishSatelliteMessage method too, since we are no longer going to publish any more messages there.
  • That will force you to modify the availabilityChecker interface to remove the EndpointAvailabilityCheck method, which is fine. Go ahead and remove the publishSatelliteMessage method from the interface too.
  • In the RequestAvailabilityCheck, you will have to remove the else if branch as well.
  • Finally, make sure you remove the unused satelliteAvailabilityMessage struct too.

With that we will have cleaned up all the satellite stuff from Sources 👍

@MikelAlejoBR
Copy link
Member

Cool, the only thing left is to remove the EndpointCounter from the dummyCheker in availability_check_test.go and run go fmt in the availability_check.go file, and I think everything should pass.

Copy link
Member

@MikelAlejoBR MikelAlejoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@MikelAlejoBR MikelAlejoBR merged commit 2906f57 into RedHatInsights:main Jan 21, 2025
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants