Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch:hosts command and update README #127

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mhuth
Copy link
Collaborator

@mhuth mhuth commented Nov 17, 2023

@johnsonm325 I was just trying to setup the project today and noticed these couple of things in the README. Hopefully these changes are correct.

@mhuth mhuth changed the title Add patch:hosts command and update npm run start command Add patch:hosts command and update README Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43a50d1) 82.53% compared to head (f02f927) 82.53%.

❗ Current head f02f927 differs from pull request most recent head dc6da9a. Consider uploading reports for the commit dc6da9a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files          62       62           
  Lines        1328     1328           
  Branches      418      418           
=======================================
  Hits         1096     1096           
  Misses        203      203           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnsonm325 johnsonm325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Thanks. LGTM

@mhuth mhuth merged commit 9f0fa4e into RedHatInsights:master Nov 22, 2023
@mhuth mhuth deleted the update_readme branch November 22, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants