DRAFT - [ADVISOR-2670] Add cancel task #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows a task, that has not been completed, to be cancelled. If a task status is "Running", the kebab dropdown on the completed tasks table should include "Cancel" instead of delete. The same is true if you view the details page of a completed task. The kebab in the right of the top header should include "Cancel" instead of delete. After clicking cancel, there are a number of things you will see in the modal. You will have the option to: Cancel a task - this will simply cancel but leave all details of the completed task in the table Cancel and delete a task - this will remove the task from your table and the backend will handle cancelling and deleting. Additionally, a task can only cancel jobs on systems that are connected via Satellite. A system with any other means of connection cannot be cancelled. Therefore, when entering the cancel modal, if any system is NOT connected via Satellite, there will be a sentence in the modal body stating, "Tasks running on systems connected with rhc cannot be cancelled." Likewise, if a task is running on systems ONLY connected via Satellite, that sentence will not be visible. Now, at this point, cancelling isn't working properly. The backend is not able to properly cancel a task. So, when you cancel a task, you'll notice the task returns a status of "Cancelled", but the jobs will still say they are "Running". This much is normal. What we would expect is to eventually see those jobs return as "Cancelled" if they are connected via Satellite, and some other status if they are connected via rhc. But what currently happens is all systems finish their runs and the status of the task completes and the "Run end" value includes a successful run completion time. The frontend code should work fine when the backend code is implemented.
Codecov ReportBase: 84.32% // Head: 83.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 84.32% 83.84% -0.49%
==========================================
Files 45 45
Lines 957 978 +21
Branches 294 305 +11
==========================================
+ Hits 807 820 +13
- Misses 133 141 +8
Partials 17 17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
johnsonm325
changed the title
|
@johnsonm325 Reviewed the PR - sent you a message on slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a task, that has not been completed, to be cancelled. If a task status is "Running", the kebab dropdown on the completed tasks table should include "Cancel" instead of delete. The same is true if you view the details page of a completed task. The kebab in the right of the top header should include "Cancel" instead of delete.
After clicking cancel, there are a number of things you will see in the modal. You will have the option to:
Additionally, a task can only cancel jobs on systems that are connected via Satellite. A system with any other means of connection cannot be cancelled. Therefore, when entering the cancel modal, if any system is NOT connected via Satellite, there will be a sentence in the modal body stating, "Tasks running on systems connected with rhc cannot be cancelled." Likewise, if a task is running on systems ONLY connected via Satellite, that sentence will not be visible.
Now, at this point, cancelling isn't working properly. The backend is not able to properly cancel a task. So, when you cancel a task, you'll notice the task returns a status of "Cancelled", but the jobs will still say they are "Running". This much is normal. What we would expect is to eventually see those jobs return as "Cancelled" if they are connected via Satellite, and some other status if they are connected via rhc. But what currently happens is all systems finish their runs and the status of the task completes and the "Run end" value includes a successful run completion time.
The frontend code should work fine when the backend code is implemented.