Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaw impact adjustment from NVD collector #907

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

jobselko
Copy link
Contributor

@jobselko jobselko commented Feb 12, 2025

This PR fixes/removes the clumsy changes introduced in #825. These changes (and some code around) are no longer needed because #890 changed how the FlawCVSS model is validated. Instead of validating all CVSS scores, only the RH CVSS3 score is validated. The NVD collector only touches NIST CVSS scores, so no code adjustments are required.

Closes OSIDB-3678

@jobselko jobselko self-assigned this Feb 12, 2025
@jobselko jobselko marked this pull request as ready for review February 12, 2025 15:19
@jobselko jobselko requested a review from a team February 12, 2025 15:19
Copy link
Contributor

@osoukup osoukup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jobselko jobselko added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit ad1e220 Feb 13, 2025
11 checks passed
@jobselko jobselko deleted the nvd_impact_adjustment branch February 13, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants