✨ OSIDB-3562: Flaw history filtering #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarble
reviewed
Nov 12, 2024
Comment on lines
20
to
23
| let subject: VueWrapper<InstanceType<typeof FlawHistory>>; | ||
|
|
||
| osimEmptyFlawTest('is not shown if no history present on flaw', async ({ flaw }) => { | ||
| const subject = mount(FlawHistory, { | ||
| subject = mount(FlawHistory, { |
There was a problem hiding this comment.
Why this change?
This is the only test that uses the top level subject
There was a problem hiding this comment.
That was probably missed from a reverted change I tried. I'll correct it.
C-Valen
force-pushed
the
feature/OSIDB-3562-flaw-history-filtering
branch
2 times, most recently
from
461164b
to
7223c06
Compare
superbuggy
reviewed
Nov 14, 2024
src/components/FlawHistory.vue
Outdated
| return !startDate.value && !endDate.value; | ||
| }); | ||
|
|
||
| const validDateRange = computed(() => { |
There was a problem hiding this comment.
Suggested change
| const validDateRange = computed(() => { | |
| const isDateRangeValid = computed(() => { |
superbuggy
reviewed
Nov 14, 2024
src/components/FlawHistory.vue
Outdated
Comment on lines
41
to
42
| const start = new Date(startDate.value!); | ||
| const end = new Date(endDate.value!); |
There was a problem hiding this comment.
specify time boundaries here: for start use 00:00 UTC and for end 23:59 UTC
superbuggy
reviewed
Nov 14, 2024
src/components/FlawHistory.vue
Outdated
| return itemDate.toDateString() === start.toDateString(); | ||
| } else { | ||
| // Otherwise, return items within the range | ||
| return itemDate >= start && itemDate <= end; |
There was a problem hiding this comment.
Suggested change
| return itemDate >= start && itemDate <= end; | |
| // if you have end date be one day ahead of the user selected end date | |
| return itemDate >= start && itemDate < end; |
MrMarble
previously approved these changes
Nov 14, 2024
src/components/FlawHistory.vue
Outdated
Comment on lines
49
to
51
| if (start.toDateString() === end.toDateString()) { | ||
| // Check if the item's date is on the exact day of start and end | ||
| return itemDate.toDateString() === start.toDateString(); |
There was a problem hiding this comment.
Suggested change
| if (start.toDateString() === end.toDateString()) { | |
| // Check if the item's date is on the exact day of start and end | |
| return itemDate.toDateString() === start.toDateString(); | |
| if (start === end) { | |
| // Check if the item's date is on the exact day of start and end | |
| return itemDate === start; |
C-Valen
force-pushed
the
feature/OSIDB-3562-flaw-history-filtering
branch
from
7223c06
to
75ce7a3
Compare
MrMarble
reviewed
Nov 19, 2024
There was a problem hiding this comment.
This widget is lacking tests, maybe is a good opportunity to add them, at least to test the new functionality
MrMarble
previously approved these changes
Nov 19, 2024
MrMarble
reviewed
Nov 19, 2024
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Fix the changelog after release merge
♻️ Use history as component property instead whole flaw ✨ Allow custom placeholder
✨ Clear filters button
C-Valen
force-pushed
the
feature/OSIDB-3562-flaw-history-filtering
branch
from
75ce7a3
to
fbe38f5
Compare
superbuggy
reviewed
Nov 21, 2024
Co-authored-by: James Reichard <[email protected]>
superbuggy
reviewed
Nov 21, 2024
| stubs: { | ||
| EditableDate: true, | ||
| }, | ||
| }, | ||
| }); | ||
| const historyListItem = subject.find('li div'); | ||
| expect(historyListItem?.text()).includes('Update Owner:'); |
There was a problem hiding this comment.
Adding tests for the date range filtering would be awesome
There was a problem hiding this comment.
Will do that, and also as discussed adding a test for EditableDate making sure that it renders and the property placeholder works as expected.
superbuggy
requested changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSIDB-3562: Flaw history filtering
Checklist:
Summary:
Implementation of date range filter on the flaw history.
Changes:
EditableDateFlawHistorytest cases and snapshotsConsiderations:
Closes OSIDB-3562