-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ OSIDB-3512: Add component column to trackers table #491
Merged
C-Valen
merged 3 commits into
main
from
feature/OSIDB-3512-component-column-trackers-table
Nov 26, 2024
Merged
✨ OSIDB-3512: Add component column to trackers table #491
C-Valen
merged 3 commits into
main
from
feature/OSIDB-3512-component-column-trackers-table
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbuggy
previously approved these changes
Nov 21, 2024
MrMarble
previously approved these changes
Nov 21, 2024
superbuggy
reviewed
Nov 21, 2024
@@ -295,6 +296,7 @@ const { | |||
</span> | |||
</td> | |||
<td :title="tracker.ps_module">{{ tracker.ps_module }}</td> | |||
<td :title="tracker.ps_component">{{ tracker.ps_component }}</td> | |||
<td :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td> | |||
<td>{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td> | |||
<td>{{ tracker.resolution?.toUpperCase() }}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- <td :title="tracker.ps_module">{{ tracker.ps_module }}</td>
- <td :title="tracker.ps_component">{{ tracker.ps_component }}</td>
- <td :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td>
- <td>{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td>
- <td>{{ tracker.resolution?.toUpperCase() }}</td>
- <td>{{ formatDate(tracker.created_dt ?? '', true) }}</td>
- <td>{{ formatDate(tracker.updated_dt ?? '', true) }}</td>
+ <td colspan="1" :title="tracker.ps_module">{{ tracker.ps_module }}</td>
+ <td colspan="1" :title="tracker.ps_component">{{ tracker.ps_component }}</td>
+ <td colspan="1" :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td>
+ <td colspan="1">{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td>
+ <td colspan="1">{{ tracker.resolution?.toUpperCase() }}</td>
+ <td colspan="1">{{ formatDate(tracker.created_dt ?? '', true) }}</td>
+ <td colspan="1">{{ formatDate(tracker.updated_dt ?? '', true) }}</td>
This approach might let us get rid of the CSS width declaration for these td
s
C-Valen
force-pushed
the
feature/OSIDB-3512-component-column-trackers-table
branch
from
November 26, 2024 08:54
269826e
to
ad9e242
Compare
C-Valen
force-pushed
the
feature/OSIDB-3512-component-column-trackers-table
branch
from
November 26, 2024 09:01
ad9e242
to
e4dfdd6
Compare
MrMarble
approved these changes
Nov 26, 2024
superbuggy
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
C-Valen
deleted the
feature/OSIDB-3512-component-column-trackers-table
branch
November 26, 2024 15:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSIDB-3512: Add component column to trackers table
Checklist:
Summary:
Adds component column to trackers table to make easier to identify for what component each tracker was created for.
Changes:
displayedTrackers
prop onFlawAffects
FlawTrackers
using new data coming in the property of the componentConsiderations:
TrackerWithModule
has been kept the same despite now also includes the component from the affectCloses OSIDB-3512