Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ OSIDB-3512: Add component column to trackers table #491

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

C-Valen
Copy link
Member

@C-Valen C-Valen commented Nov 21, 2024

OSIDB-3512: Add component column to trackers table

Checklist:

  • Commits consolidated
  • Changelog updated
  • Test cases added/updated
  • Jira ticket updated

Summary:

Adds component column to trackers table to make easier to identify for what component each tracker was created for.

Changes:

  • Add component to displayedTrackers prop on FlawAffects
  • Add new component column on FlawTrackers using new data coming in the property of the component
  • Adjust column widths

Considerations:

  • Type name TrackerWithModule has been kept the same despite now also includes the component from the affect

Closes OSIDB-3512

@C-Valen C-Valen added the enhancement New feature or request label Nov 21, 2024
@C-Valen C-Valen self-assigned this Nov 21, 2024
superbuggy
superbuggy previously approved these changes Nov 21, 2024
MrMarble
MrMarble previously approved these changes Nov 21, 2024
@@ -295,6 +296,7 @@ const {
</span>
</td>
<td :title="tracker.ps_module">{{ tracker.ps_module }}</td>
<td :title="tracker.ps_component">{{ tracker.ps_component }}</td>
<td :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td>
<td>{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td>
<td>{{ tracker.resolution?.toUpperCase() }}</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-              <td :title="tracker.ps_module">{{ tracker.ps_module }}</td>
-              <td :title="tracker.ps_component">{{ tracker.ps_component }}</td>
-              <td :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td>
-              <td>{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td>
-              <td>{{ tracker.resolution?.toUpperCase() }}</td>
-              <td>{{ formatDate(tracker.created_dt ?? '', true) }}</td>
-              <td>{{ formatDate(tracker.updated_dt ?? '', true) }}</td>
+              <td colspan="1" :title="tracker.ps_module">{{ tracker.ps_module }}</td>
+              <td colspan="1" :title="tracker.ps_component">{{ tracker.ps_component }}</td>
+              <td colspan="1" :title="tracker.ps_update_stream ?? ''">{{ tracker.ps_update_stream }}</td>
+              <td colspan="1">{{ tracker.status?.toUpperCase() || 'EMPTY' }}</td>
+              <td colspan="1">{{ tracker.resolution?.toUpperCase() }}</td>
+              <td colspan="1">{{ formatDate(tracker.created_dt ?? '', true) }}</td>
+              <td colspan="1">{{ formatDate(tracker.updated_dt ?? '', true) }}</td>

This approach might let us get rid of the CSS width declaration for these tds

@C-Valen C-Valen dismissed stale reviews from MrMarble and superbuggy via ad9e242 November 26, 2024 08:54
@C-Valen C-Valen force-pushed the feature/OSIDB-3512-component-column-trackers-table branch from 269826e to ad9e242 Compare November 26, 2024 08:54
@C-Valen C-Valen force-pushed the feature/OSIDB-3512-component-column-trackers-table branch from ad9e242 to e4dfdd6 Compare November 26, 2024 09:01
Copy link
Collaborator

@superbuggy superbuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@C-Valen C-Valen merged commit b365c72 into main Nov 26, 2024
5 checks passed
@C-Valen C-Valen deleted the feature/OSIDB-3512-component-column-trackers-table branch November 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants