don't stop/start crond and don't start services after restore #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreman-maintain takes care of all that, no need to duplicate work
ekohl
approved these changes
Jun 6, 2024
|
|
||
| - name: Restart services | ||
| command: foreman-maintain service start | ||
|
|
||
| # We don't use pause module here because it displays a prompt | ||
| # to use ctrl+c which would break out of a production script. | ||
| - name: Wait for foreman-tasks service to start |
There was a problem hiding this comment.
Is the sleep still needed? By now, don't we guarantee services being available after systemctl start $service?
There was a problem hiding this comment.
one hunk at a time ;)
foreman-tasks takes a moment to assemble, so hammer ping often shows that one as "dead" if you do it directly after, but the sleep is certainly too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman-maintain takes care of all that, no need to duplicate work