Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QoL and new Questions #73

Merged
merged 25 commits into from
Jan 27, 2025
Merged

QoL and new Questions #73

merged 25 commits into from
Jan 27, 2025

Conversation

RedzepR
Copy link
Contributor

@RedzepR RedzepR commented Jan 7, 2025 •
edited
Loading

Adds two new Questions in relation to dungeons

  • Name a Pokemon that can be caught in this dungeon
  • Name a Dungeon this Pokemon can be caught in

Various QoL changes

  • Give starting town questions a new icon so it can be more easily distinguished from dock questions
  • Make dual type questions not weighted
  • Make type region questions not weighted
  • Make gym location not require the number (but optional)
  • Remove gym leaders who have no location in the location question
  • Rewrite a bit of code

RedzepR and others added 23 commits December 27, 2024 18:26
@RedzepR
Change the starting town question image to a blimp
737f900
@RedzepR
Make dualType Question be unweighted by commonness of the type combin…
2787cfa 
…ation
@RedzepR
Randomize the chosen blimp for starting questions
92e337e
@RedzepR
Optimize TypeRegionQuestion
d9af8fc
@RedzepR
fix weight
49e5ab3
@RedzepR
fix region questions
c59b93b
@RedzepR
New question type
fab0e86
@RedzepR
bugfix
bb0c8d6
@RedzepR
New question
e03464e
@RedzepR
Merge branch 'RedSparr0w:v14' into FixCoins
f9b25a6
@RedzepR
Eslint fix
067ee8e
@RedzepR
Eslint
30124b9
@RedzepR
Add Nebby as a joke answer to cosmog
79dc026
@RedzepR
Make gym locations not require the number (circhester1/circhester2)
c041b19
@RedzepR
Remove GymLeaders whos ""town"" is themself (AI Sada, AI Turo, Champi…
5bb1782 
…on Hau)
@RedzepR
Add skarmory reaction
0d51082
@RedzepR
fix location question (more than just gordie)
c327e5c
@RedzepR
eslint
5327556
@RedzepR
Bugfix + allow mega stone names to be answered
07f726d
@RedzepR
missing )
a781b96
@RedSparr0w
Merge branch 'v14' into FixCoins
36b2ddf
@RedSparr0w
exlint fixes
ffa5801
@RedSparr0w
Update quiz_questions.js
4e945e6
RedSparr0w
RedSparr0w approved these changes Jan 27, 2025
View reviewed changes
Copy link
Owner

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had a chance to test it out, code looks fine though, thanks for the PR! 👍

@RedSparr0w RedSparr0w merged commit 40aeeea into RedSparr0w:v14 Jan 27, 2025
1 check passed
@RedzepR RedzepR deleted the FixCoins branch January 28, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedSparr0w RedSparr0w RedSparr0w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedzepR @RedSparr0w