Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add print frequency #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wanghenshui
Copy link

log message is to much when encountered an connect error and I add this option to control print frequency

@wanghenshui
Copy link
Author

ping @yossigo

@yossigo
Copy link
Contributor

yossigo commented Jun 11, 2020

@wanghenshui thank you! Just be sure I understand correctly, so you basically want the ability to bump up the print rate to overcome lots of messages produced by benchmark_*_log() prints on connection errors, etc.?

Did you consider an option to suppress those messages altogether, possibly narrowing it down to an additional errors counter?

@wanghenshui
Copy link
Author

@wanghenshui thank you! Just be sure I understand correctly, so you basically want the ability to bump up the print rate to overcome lots of messages produced by benchmark_*_log() prints on connection errors, etc.?

Did you consider an option to suppress those messages altogether, possibly narrowing it down to an additional errors counter?

we use memtier_benchmark as a stress tool, stress our redis-like server every day, print a log per second is also too much for analyze.

narrowing it down to an additional errors counter is also a good idea, maybe i implement it in next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants