-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc ssl #246
Open
gkorland
wants to merge
10
commits into
master
Choose a base branch
from
doc-ssl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Doc ssl #246
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c82d47
add ssl connection test
gkorland 89a41da
add keystore
gkorland ff69238
Update Makefile
gkorland 6fe3e77
Update Makefile
gkorland ee709d5
set keystore
gkorland 1c36ab6
Merge branch 'ssl-test' of github.com:RedisLabs/spark-redis into ssl-…
gkorland eb9bc7c
add ssl to docs
gkorland d77e506
Merge branch 'master' into doc-ssl
gkorland 648714d
Merge branch 'master' into doc-ssl
gkorland ebe9ab4
Merge branch 'master' into doc-ssl
gkorland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should include this line into the doc. It's only needed if someone starts Redis with a generated CA certificate. And in that case if they submit an app to spark cluster, they will need to configure java options in spark specific way, i.e. using
spark.executor.extraJavaOptions
andspark.driver.extraJavaOptions
(https://spark.apache.org/docs/latest/configuration.html). Maybe we should create a separate doc page describing it since it's more advanced topic (not for a getting-started page). What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a good idea.