Added the option to set ttl from a column. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SariNusier
commented
Nov 26, 2020
•
SariNusier
commented
- If ttl.column is set, the connector will use the value in that column to set the ttl of the record.
- The ttl column will not be included in the fields of the record.
added 4 commits
November 26, 2020 10:26
- If ttl.column is set, the connector will use the value in that column to set the ttl of the record. - The ttl column will not be included in the fields of the record. - The ability to use a constant ttl is still there, but ttl.column takes precedence when both are set.
fe2s
requested changes
Jan 16, 2021
There was a problem hiding this comment.
Hi @SariNusier
Thank you for the PR! It looks good in general.
Could you please also update documentation and tests?
| @@ -25,7 +25,7 @@ class BinaryRedisPersistence extends RedisPersistence[Array[Byte]] { | |||
| override def load(pipeline: Pipeline, key: String, requiredColumns: Seq[String]): Unit = | |||
| pipeline.get(key.getBytes(UTF_8)) | |||
|
|
|||
| override def encodeRow(keyName: String, value: Row): Array[Byte] = { | |||
| override def encodeRow(keyName: String, value: Row, ttlColumn: Option[String] = None): Array[Byte] = { | |||
| val fields = value.schema.fields.map(_.name) | |||
| val valuesArray = fields.map(f => value.getAs[Any](f)) | |||
There was a problem hiding this comment.
should we exclude TTL column here as well?
| @@ -39,6 +39,13 @@ class HashRedisPersistence extends RedisPersistence[Any] { | |||
| // don't store key values | |||
| k != keyName | |||
| } | |||
| .filter { case (k, _) => | |||
| // don't store TTLs | |||
| ttlColumn match { | |||
There was a problem hiding this comment.
It's probably more efficient in terms of the performance to check if ttlColumn is specified only once rather than for every field.
| val encodedRow = persistence.encodeRow(keyName, row) | ||
| persistence.save(pipeline, key, encodedRow, ttl) | ||
| val encodedRow = persistence.encodeRow(keyName, row, ttlColumn) | ||
| val recordTTL = if (ttlColumn.isEmpty) ttl else row.getAs[Int](ttlColumn.get) |
There was a problem hiding this comment.
We can rewrite it with val recordTTL = ttlColumn.map(v => row.getAs[Int](v)).getOrElse(ttl). It looks to be more idiomatic approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.