Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recolor icon.svg to fit project rebranding #687

Closed
wants to merge 3 commits into from

Conversation

Majoramari
Copy link
Contributor

@Majoramari Majoramari commented Oct 12, 2024

A recoloring of the default icon to match the new colors of our beloved Redot engine!

The rebranding has some coloring and UX issues. I’m planning to open an issue to track them, but let's start with this.

This PR could possibly start helpin' with #688 and #657

@RadenTheFolf
Copy link
Contributor

Was this saved as a plain svg or an inkscape svg? It should be a plain svg. it should also be passed through svgcleaner as described here https://docs.godotengine.org/en/stable/contributing/development/editor/creating_icons.html

@RadenTheFolf RadenTheFolf added the rebranding issues and pr's related to engine rebranding label Oct 12, 2024
@SkogiB
Copy link
Contributor

SkogiB commented Oct 12, 2024

Was this saved as a plain svg or an inkscape svg? It should be a plain svg. it should also be passed through svgcleaner as described here https://docs.godotengine.org/en/stable/contributing/development/editor/creating_icons.html

We really need to fix the .svg workflow man lmao

Good fix though, looking forward to merging

@Majoramari
Copy link
Contributor Author

Majoramari commented Oct 12, 2024

Was this saved as a plain svg or an inkscape svg? It should be a plain svg. it should also be passed through svgcleaner as described here https://docs.godotengine.org/en/stable/contributing/development/editor/creating_icons.html

Thanks for guiding me in the right direction, and sorry for any confusion.

This time, I followed the guide and saved it as a plain SVG instead of an Inkscape SVG!

I also cleaned it using svgcleaner as shown below:

It's now 1.4 KB in size, which is smaller than the already existing one (2.4 KB).

svgcleaner --multipass svg_source.svg svg_optimized.svg

NOTE: The project is archived, so I guess we should start using an alternative.

Please let me know if there's anything that needs to be changed.

@tokengamedev
Copy link
Contributor

tokengamedev commented Oct 13, 2024

Please take a note at the issue I have raised Redot-Engine/redot-proposals#23

@Majoramari Majoramari closed this by deleting the head repository Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding issues and pr's related to engine rebranding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants