Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor API + PuzzleBang Changes #115

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Refactor API + PuzzleBang Changes #115

merged 6 commits into from
Jul 31, 2024

Conversation

AydanPirani
Copy link
Contributor

Allow support for new PuzzleBang code.

@AydanPirani AydanPirani requested a review from divyack2 July 27, 2024 08:13
benjuang
benjuang reviewed Jul 28, 2024
View reviewed changes
Copy link

@benjuang benjuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the single comment around checking attendeeData.puzzlesCompleted.includes(requestInfo.puzzleId)

src/services/puzzlebang/puzzlebang-router.ts Show resolved Hide resolved
divyack2
divyack2 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AydanPirani AydanPirani merged commit fa205e1 into main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjuang benjuang benjuang left review comments

@divyack2 divyack2 divyack2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AydanPirani @benjuang @divyack2