Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 service for resume upload / download #27

Merged
merged 7 commits into from
Apr 24, 2024
Merged

S3 service for resume upload / download #27

merged 7 commits into from
Apr 24, 2024

Conversation

aletya
Copy link
Contributor

@aletya aletya commented Apr 23, 2024

/s3/upload

  • returns url and fields necessary to upload to our S3 bucket (POST)
  • can only be called for oneself
  • can be called by USER+

/s3/download

  • returns url to download user's resume from our S3 bucket (GET)
  • can only be called for oneself
  • can be called by USER+

/s3/download/:USERID

  • returns url to download specific user's resume from our S3 bucket (GET)
  • can only be called by ADMIN

AydanPirani
AydanPirani approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

divyack2
divyack2 requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just resolve the merge conflicts and you should be good to go :)

@aletya
Copy link
Contributor Author

aletya commented Apr 24, 2024

just resolve the merge conflicts and you should be good to go :)

resolved!

@aletya aletya closed this Apr 24, 2024
@aletya aletya reopened this Apr 24, 2024
divyack2
divyack2 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aletya aletya merged commit e7b692d into main Apr 24, 2024
3 checks passed
@aletya aletya deleted the dev/alex/s3-service branch April 24, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyack2 divyack2 divyack2 approved these changes

@AydanPirani AydanPirani AydanPirani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aletya @AydanPirani @divyack2