Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth Workflow, JWT, Role Checking #6

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Auth Workflow, JWT, Role Checking #6

merged 10 commits into from
Apr 11, 2024

Conversation

AydanPirani
Copy link
Contributor

Add support for google oauth

@AydanPirani AydanPirani requested a review from divyack2 April 8, 2024 06:25
@AydanPirani AydanPirani changed the title [DRAFT] Auth Auth Workflow, JWT, Role Checking Apr 11, 2024
@AydanPirani AydanPirani marked this pull request as ready for review April 11, 2024 16:18
divyack2
divyack2 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all makes sense to me! one small question + we can probably add some comments in later to better explain what's going on

src/services/auth/auth-models.ts Outdated Show resolved Hide resolved
divyack2
divyack2 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :))

@AydanPirani AydanPirani merged commit 3cd8e1e into main Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyack2 divyack2 divyack2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AydanPirani @divyack2