Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed login screen for different phone sizes #22

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

aryan-bhardwaj
Copy link
Contributor

Login page with SVG able to adapt to screen sizes

Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits: could you remove the console logs and see if there's a way to pull the authUrl and redirectUrl into some kind of config file (just to make it look cleaner)

but overall looks good to me!

@aryan-bhardwaj
Copy link
Contributor Author

Removed console logs. I didn't make a config and kept the URLs in the Login file, because those are just used for Login purposes so it didn't make sense to make a config file for it.

Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aryan-bhardwaj aryan-bhardwaj merged commit f0fe9e6 into main Jul 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants