Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prize svg #32

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Prize svg #32

merged 6 commits into from
Sep 6, 2024

Conversation

aryan-bhardwaj
Copy link
Contributor

now question marks should appear if there is no token. prizes should appear as you earn more points.

Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small changes!

screens/Login.tsx Outdated Show resolved Hide resolved
Components/PrizeSVG.tsx Outdated Show resolved Hide resolved
Components/PrizeSVG.tsx Outdated Show resolved Hide resolved
screens/Shop.tsx Outdated Show resolved Hide resolved
screens/Shop.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one final small number change!

const svgMap: { [key: number]: JSX.Element } = {
1: <Button width={size} height={size}/>,
2: attendeePoints >= 20 ? <ToteBag width={size} height={size}/> : <Question2 width={size} height={size}/>,
3: attendeePoints >= 35 ? <Cap width={size} height={size}/> : <Question3 width={size} height={size}/>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix these thresholds still :') it should be 20, 35, and 50

token: string;
}

const FoodWaveSVG: React.FC<PrizeSVGProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh nit but this should be named PrizeSVG or smth right

Copy link
Contributor

@divyack2 divyack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@aryan-bhardwaj aryan-bhardwaj merged commit 4c5baac into main Sep 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants