-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Schema.NET.Pending project for pending types #302
Conversation
A quick look suggests we might need another variation of our |
We can't share the value because the data is different between projects. It does mean each target framework will re-process the data though that isn't a huge issue.
I've got it working! The builds will take about 2x longer now (likely also making Visual Studio a little more sluggish) but we get the functionality we want. |
Once we've got this in, should we release a new version (and thus the first version of Schema.NET.Pending)? |
Just want to make sure before I create a new release that the NuGet key you've configured for the repo has the "Create new packages" permission. I've had issues before of not doing that and then manually having to remove tags/releases and re-running it. |
Write permissions for GitHub packages are in the build: I recently switched to using this least priviledge approach for all my repos and defaulted to read rights in settings: Only downside is that autolabeller seems to have stopped working and I have no idea why: |
Ahhhh, sorry, I meant permissions in NuGet.org itself. So when you have your API key in NuGet, you get a screen like this: What I'm referring to is whether you have "Push new packages and package versions" or whether it is "Push new package versions". With our "Schema.NET.Pending" library, it will need that unless you want to upload the first package for it manually. |
Oh I see. I have one key per project and get notified when they expire, so we won't have that problem. |
Looks like we might have missed something. The Schema.NET.Pending package didn't push to NuGet and the one that pushed to GitHub Packages isn't correctly versioned... 🤔 |
I think the |
Fixed in #303. Will delete the tag and re-release. Annoying but required. |
Cheers mate! |
Will close #203
The core changes:
I don't think I have this quite right yet (particularly around pulling in the setting) but is the general gist of the changes required to support pending types.
Once #301 is in, it will make debugging this easier and then hopefully we can get full pending types supported!