Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 iujuuuu!!! #62

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Version 2 iujuuuu!!! #62

wants to merge 10 commits into from

Conversation

Chugeno
Copy link

@Chugeno Chugeno commented Dec 11, 2024

Enhanced Version of Domestika Downloader

Dear Rene,

First, I want to thank you for creating this amazing tool that has inspired me to add new features and improvements. I'd love to share these enhancements with you and the community!

(Note: I'm using a translator as I'm a Spanish speaker)

Major Improvements:

Enhanced URL Support

  • Now accepts multiple URL formats (not just those ending in /courses)
  • Multiple URLs can be processed in one go (separated by spaces)
  • Automatically downloads all courses from the provided URLs

macOS Compatibility

  • Mac support only, I am working to make it work on windows.
  • Improved file handling for macOS environment

Interactive Cookie Management

  • Interactive cookie input process
  • Clear instructions on how to obtain cookies from browser
  • Error handling with retry option:
    • If authentication fails, offers to input new cookie values
    • Program automatically restarts with new credentials
    • User-friendly feedback during the process

Enhanced Video Processing

  • Automatic subtitle download and embedding
  • Improved video naming convention
  • Better organization of downloaded content

User Experience

  • More intuitive interface
  • Better error messages and handling
  • Progress indicators for downloads
  • Automatic retry on connection failures

Modified Files:

  • auth.js (Enhanced authentication system)
  • index.js (Core functionality improvements)
  • .gitignore (Better file exclusion rules)
  • package.json (Updated dependencies)
  • .env.example (Added for easier setup)
  • README.md (Updated documentation)

Technical Improvements:

  • Better environment variable handling
  • Enhanced error handling and recovery
  • Improved authentication flow
  • More robust download process

Testing:

All features have been thoroughly tested on macOS and are working as expected.

I would love for you to try this version and provide any feedback. Your project has been a great inspiration, and I hope these additions can contribute to making it even better!

Thank you again for your original work that made this possible!

Best regards,
Eugenio

@Hermit6202
Copy link

Hermit6202 commented Jan 2, 2025

I tried it on windows 10 but it don't work. Don't ask for URL, and don't accept the session cookies. Only errors, errors, errors

@Chugeno
Copy link
Author

Chugeno commented Jan 3, 2025

Hi Hermit, thanks for replying and taking the time to test. Yes indeed I couldn't test what I did in windows, I have to adapt the code and the truth is that I didn't have time and I don't have a PC with windows either. I will try in the next few days to test on windows since I did it exclusively for Mac for now. I will update my README to clarify this.
As soon as I can test it I will let you know so you can try it.

- Improved code structure with mac/win separation
- Added system detection in start.js
- Removed unused dependencies
- Updated README files with macOS notice
- Cleaned up code and improved error handling
- Added proper module exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants