[ZEN-4921] Parameter and header code assist is incomplete; style parameter should show enumerated values #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter should show enumerated values Added style values as enum in openapi schema.
tedepstein
reviewed
Sep 13, 2019
| "spaceDelimited", | ||
| "pipeDelimited", | ||
| "deepObject" | ||
| ] |
There was a problem hiding this comment.
The style property also applies to header (see Header Object) and encoding (Encoding Object). I think it makes sense to extract this string enum type as its own styleEnum schema, and reference that schema from all three contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added style values as enum in openapi schema.