Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to latest RN SDK versions #7

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

MantisClone
Copy link
Member

@MantisClone MantisClone commented Jul 24, 2024

Towards RequestNetwork/public-issues#39

Summary by CodeRabbit

  • New Features

    • Introduced a new script command npm run declare for payment declaration.
    • Added functionality for managing payment requests using Ethereum transactions.
  • Bug Fixes

    • Updated dependency versions to enhance functionality and reliability.
  • Documentation

    • Updated the README.md to reflect the new command and its purpose.
  • Refactor

    • Improved code readability by consolidating function parameters and removing duplicate imports.

Copy link

coderabbitai bot commented Jul 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new script command npm run declare in the README.md and package.json files, which executes a newly added JavaScript file src/declarePaymentSentAndReceived.js. This script implements a payment request system using the Request Network protocol for Ethereum transactions. Additionally, updates to dependency versions enhance the functionality of the package while maintaining existing features.

Changes

File(s) Change Summary
README.md, package.json Added npm run declare script to README.md and package.json, introducing a new command that executes src/declarePaymentSentAndReceived.js.
package.json Added new script "declare": "node src/declarePaymentSentAndReceived.js" and updated dependency versions: @requestnetwork/epk-signature to 0.8.0, @requestnetwork/payment-processor to 0.46.0, and @requestnetwork/request-client.js to 0.48.0.
src/declarePaymentSentAndReceived.js Introduced a new file implementing a payment request system for Ethereum transactions, managing the creation and confirmation of payment requests between payer and payee.
src/payRequest.js Refactored hasSufficientFunds function to use a single object parameter instead of multiple arguments and removed a duplicate import of Wallet from the ethers library.

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MantisClone MantisClone marked this pull request as ready for review September 3, 2024 20:34
@MantisClone
Copy link
Member Author

Merging without review because this was already reviewed in #8

@MantisClone MantisClone changed the title Upgrade to latest RN SDK versions chore: Upgrade to latest RN SDK versions Sep 3, 2024
@MantisClone MantisClone merged commit b552378 into main Sep 3, 2024
@MantisClone MantisClone deleted the upgrade-sdk branch September 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant