chore: update the sdk version #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant A as User
participant B as Application
participant C as Request Client
A->>B: Request to update dependency
B->>C: Update @requestnetwork/request-client.js to 0.49.0
C-->>B: Confirmation of update
B-->>A: Dependency updated successfully
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (1)package.json (1)
The version bump from 0.48.0 to 0.49.0 looks good, but let's ensure compatibility with other @RequestNetwork packages in use. ✅ Verification successfulVersion update appears safe to proceed The codebase analysis shows:
While we couldn't access the release notes directly, the minor version bump and the straightforward usage patterns suggest this update is safe. The tight integration between these packages in the codebase indicates they're designed to work together across minor versions. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check compatibility between @requestnetwork packages and look for breaking changes
# Test 1: Check if there's a changelog or release notes for version 0.49.0
echo "Checking for breaking changes in version 0.49.0..."
gh release view v0.49.0 --repo requestnetwork/request-client.js 2>/dev/null || echo "Release notes not found"
# Test 2: Look for version compatibility documentation
echo "Checking for version compatibility documentation..."
fd -t f "README.md" | xargs rg -l "@requestnetwork/(request-client\.js|epk-signature|payment-processor).+version"
Length of output: 460 Script: #!/bin/bash
# Let's try a different approach to verify compatibility
# Check for any imports or usage patterns of these packages together
echo "Checking for usage patterns of @requestnetwork packages..."
rg -l "@requestnetwork" --type ts --type js
# Look for package-lock.json to see if there are any peer dependency requirements
echo -e "\nChecking package-lock.json for dependency relationships..."
if [ -f "package-lock.json" ]; then
cat package-lock.json | jq '.packages | .[] | select(.name | contains("@requestnetwork"))'
fi
# Check the exact version being updated from
echo -e "\nChecking git history for previous version..."
git log -p package.json | rg -B1 -A1 '"@requestnetwork/request-client.js":'
Length of output: 1130 Script: #!/bin/bash
# Let's examine the actual usage of these packages in the codebase
echo "Checking how these packages are used together..."
for file in src/retrieveRequest.js src/declarePaymentSentAndReceived.js src/createRequest.js src/payRequest.js; do
echo -e "\n=== $file ==="
rg "@requestnetwork" "$file" -B2 -A2
done
# Check if there are any peer dependencies specified in package.json
echo -e "\nChecking for peer dependencies..."
if [ -f "package.json" ]; then
cat package.json | jq '.peerDependencies'
fi
Length of output: 2298 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
MantisClone
approved these changes
Oct 30, 2024
MantisClone
requested changes
Oct 30, 2024
There was a problem hiding this comment.
I tried the pay script and it hung when checking if the payer had sufficient funds. @sstefdev can you investigate why?
npm run pay
> [email protected] pay
> node src/payRequest.js
Created Request: {"_events":{},"_eventsCount":0,"currency":"FAU-sepolia","expectedAmount":"1000000000000000000","payee":{"type":"ethereumAddress","value":"0x
7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"payer":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"timestamp":1730323653,"extensionsData":[{"action":"create","id":"pn-erc20-fee-proxy-contract","parameters":{"feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","paymentNetworkName":"sepolia","salt":"02f2ab697fa2e5e6"},"version":"0.2.0"},{"action":"create","id":"content-data","parameters":{"content":{"reason":"🍕","dueDate":"2023.06.16"}},"version":"0.1.0"}],"extensions":{"pn-erc20-fee-proxy-contract":{"events":[{"name":"create","parameters":{"feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","salt":"02f2ab697fa2e5e6"},"timestamp":1730323656}],"id":"pn-erc20-fee-proxy-contract","type":"payment-network","values":{"salt":"02f2ab697fa2e5e6","receivedPaymentAmount":"0","receivedRefundAmount":"0","sentPaymentAmount":"0","sentRefundAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","feeBalance":{"events":[],"balance":"0"}},"version":"0.2.0"},"content-data":{"events":[],"id":"content-data","type":"content-data","values":{"content":{"reason":"🍕","dueDate":"2023.06.16"}},"version":"0.1.0"}},"requestId":"01e55ea4ed477c4d42e3e52190ec4425428479af36f8235f81024d5cb8e00e5ee0","version":"2.0.3","events":[{"actionSigner":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"name":"create","parameters":{"expectedAmount":"1000000000000000000","extensionsDataLength":2,"isSignedRequest":false},"timestamp":1730323656}],"state":"created","creator":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"balance":{"balance":"0","events":[],"escrowEvents":[]},"contentData":{"reason":"🍕","dueDate":"2023.06.16"},"currencyInfo":{"type":"ERC20","value":"0x370DE27fdb7D1Ff1e1BaA7D11c5820a324Cf623C","network":"sepolia"},"meta":{"ignoredTransactions":[],"transactionManagerMeta":{"dataAccessMeta":{"transactionsStorageLocation":["QmX46DdoTU1dYbWUHcrw9DQHRJx888Bq8aavzDo7qUAVNi"],"storageMeta":[{"ethereum":{"blockConfirmation":0,"blockNumber":6979127,"blockTimestamp":1730323656,"networkName":"sepolia","smartContractAddress":"0xd6c085a4d14e9e171f4af58f7f48bd81173f167e","transactionHash":"0x48246296ab23d362ee4749f2b8c24943c9360db35a19ba5d2c598e105b8b7054"},"ipfs":{"size":1562},"state":"confirmed","storageType":"ethereumIpfs","timestamp":1730323656}]},"ignoredTransactions":[null]}},"pending":null} Checking if payer 0x519145B771a6e450461af89980e5C17Ff6Fd8A92 has sufficient funds...
^C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
@requestnetwork/request-client.jsdependency to improve performance and reliability.