Skip to content

Commit

Permalink
ci: move lint out of build (#1255)
Browse files Browse the repository at this point in the history
  • Loading branch information
benjlevesque authored Nov 17, 2023
1 parent 71b2c46 commit 07e5cad
Showing 1 changed file with 28 additions and 26 deletions.
54 changes: 28 additions & 26 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ jobs:
key: yarn-packages-{{ checksum "yarn.lock" }}
paths:
- ~/.cache/yarn
- run:
name: Verify format
command: yarn format:check
- run:
name: Verify lint
command: yarn lint:check
- run:
name: Build types
command: yarn workspace @requestnetwork/types run build
Expand All @@ -102,14 +96,21 @@ jobs:

- persist_to_workspace:
root: *working_directory
paths: .
lint-package-json:
paths:
- ./
lint:
docker:
- *node_image
working_directory: *working_directory
steps:
- attach_workspace:
at: *working_directory
- run:
name: Verify format
command: yarn format:check
- run:
name: Verify lint
command: yarn lint:check
- run:
name: 'lint package.json files'
command: 'yarn run packageJsonLint'
Expand Down Expand Up @@ -591,7 +592,7 @@ workflows:
build-and-test:
jobs:
- build
- lint-package-json:
- lint:
requires:
- build
# Test
Expand Down Expand Up @@ -659,44 +660,48 @@ workflows:
# Publish the code coverage
- publish-coverage:
requires:
- test-request-client
- lint
- test-advanced-logic
- test-currency
- test-data-access
- test-data-format
- test-transaction-manager
- test-ethereum-storage
- test-request-logic
- test-advanced-logic
- test-epk-signature
- test-web3-signature
- test-epk-decryption
- test-request-node
- test-utils
- test-currency
- test-epk-signature
- test-ethereum-storage
- test-integration-test
- test-multi-format
- test-payment-detection
- test-payment-processor
- test-request-client
- test-request-logic
- test-request-node
- test-smart-contracts
- test-transaction-manager
- test-utils
- test-web3-signature

# Release a next version package everytime we merge to master
- next-release:
requires:
- lint
- test-advanced-logic
- test-currency
- test-data-access
- test-data-format
- test-epk-decryption
- test-epk-signature
- test-ethereum-storage
- test-integration-test
- test-smart-contracts
- test-multi-format
- test-payment-detection
- test-payment-processor
- test-request-client
- test-request-logic
- test-request-node
- test-smart-contracts
- test-transaction-manager
- test-utils
- test-currency
- test-web3-signature
- test-payment-detection
- test-payment-processor
context: protocol-release
filters:
branches:
Expand All @@ -714,9 +719,6 @@ workflows:
- master
jobs:
- build
- lint-package-json:
requires:
- build
- test-nightly:
requires:
- build

0 comments on commit 07e5cad

Please sign in to comment.