Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment-processor): USDC on Near is now standard #1221

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix(payment-processor): USDC on Near is now standard #1221

merged 2 commits into from
Oct 27, 2023

Conversation

yomarion
Copy link
Member

Description of the changes

USDC appears to be standard on Near.

I could not find sources for this breaking change but executing the standard method storage_balance_of now works and check_registration breaks.

benjlevesque
benjlevesque approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@benjlevesque benjlevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, nice!

@coveralls
Copy link

Coverage Status

coverage: 86.994% (+0.1%) from 86.87% when pulling 4ba774e on fix/payment-processor-USDC-near-standard into 9021cf2 on master.

@yomarion yomarion enabled auto-merge (squash) October 27, 2023 08:50
@yomarion yomarion merged commit cb21d2a into master Oct 27, 2023
@yomarion yomarion deleted the fix/payment-processor-USDC-near-standard branch October 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KolevDarko KolevDarko KolevDarko approved these changes

@benjlevesque benjlevesque benjlevesque approved these changes

@kevindavee kevindavee kevindavee approved these changes

@olivier7delf olivier7delf olivier7delf approved these changes

@alexandre-abrioux alexandre-abrioux Awaiting requested review from alexandre-abrioux

@MantisClone MantisClone Awaiting requested review from MantisClone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yomarion @coveralls @KolevDarko @benjlevesque @kevindavee @olivier7delf