fix: prerelease git issue #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request modifies the CircleCI configuration file, specifically the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.circleci/config.yml (1)
Line range hint
288-297: Consider documenting the release process changes.While the modification correctly prevents git tag creation, it would be beneficial to:
- Document this behavior change in the repository's release documentation
- Update any CI/CD documentation that references the prerelease process
- Ensure team members are aware that prerelease versions won't create git tags
This helps maintain clarity in the release process and prevents confusion about version tracking.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.circleci/config.yml(1 hunks)
🔇 Additional comments (2)
.circleci/config.yml (2)
291-291: LGTM! The flag addition correctly addresses the prerelease git tagging issue.
The addition of --no-git-tag-version flag to the lerna publish command is appropriate and works well with the existing --no-push flag to prevent automatic git tag creation during prerelease publishing.
Line range hint 368-379: Verify the workflow dependencies remain intact.
The next-release job maintains its position in the workflow with all required checks and contexts. This ensures the release process remains secure and well-tested.
✅ Verification successful
Workflow dependencies and context are properly configured
The verification confirms that:
- The
next-releasejob maintains all required dependencies:- lint
- build
- test-unit
- test-integration-with-smart-contracts
- test-integration-with-request-node
- test-usage-examples
- test-toolbox
- The
protocol-releasecontext is correctly set - The job runs only on the master branch as intended
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the workflow dependencies and contexts
# Check if all required jobs are listed as dependencies and the context is properly set
# Test: Extract and verify next-release job dependencies
yq '.workflows."build-and-test".jobs[] | select(has("next-release")) | .next-release.requires[]' .circleci/config.yml
# Test: Verify the context setting
yq '.workflows."build-and-test".jobs[] | select(has("next-release")) | .next-release.context' .circleci/config.yml
Length of output: 422
Script:
#!/bin/bash
# Let's try a different approach using grep to verify the workflow dependencies
# First, let's get the entire next-release job configuration
grep -A 20 "next-release:" .circleci/config.yml
# Then, let's specifically look for requires and context sections
grep -A 5 "requires:" .circleci/config.yml | grep -v "^#"
grep -A 2 "context:" .circleci/config.yml | grep -v "^#"
Length of output: 2591
sstefdev
approved these changes
Dec 16, 2024
|
For posterity, here's the full error text. |
|
I wonder if we could fix it in a way so that the tagging works instead of skipping it 🤔 Nonetheless, I'll approve this change and we can revisit it later. |
MantisClone
approved these changes
Dec 17, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://app.circleci.com/pipelines/github/RequestNetwork/requestNetwork/10432/workflows/50b5a833-a542-4b28-92db-cded685106a0/jobs/159862/parallel-runs/0/steps/0-104
Description of the changes
fix: update lerna publish command to prevent git tagging during prerelease
Summary by CodeRabbit