Misc fixes for rhash #299
Merged
Misc fixes for rhash #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CasualPokePlayer
commented
Dec 12, 2023
CasualPokePlayer
commented
- Correct SEEK_END behavior for rc_file_seek_buffered_file. offset should be added, not substracted (the caller is supposed to send a negative offset here)
- Properly open UTF-8 paths on Windows (this requires conversion from UTF-8 to UTF-16 and using _wfopen_s/_wfopen).
- Correct SEEK_END behavior for rc_file_seek_buffered_file. offset should be added, not substracted (the caller is supposed to send a negative offset here) - Properly open UTF-8 paths on Windows (this requires conversion from UTF-8 to UTF-16 and using _wfopen_s/_wfopen).
Jamiras
reviewed
Dec 15, 2023
Jamiras
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.