use modified memref chain for mathematic rich presence macro values #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the overhead of creating a value object for macro parameters that are simple mathematic expressions:
Would create:
Which would intrinsically have a modified memref chain of "byte 0x1234 * 100 + byte 0x1235". This updates the logic so the macro can reference the chain directly without needing to define the conditions or the condition container.
More complex parameters (i.e. something counting hits or something with a PauseIf) would still need to generate the more complex container.