Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modified memref chain for mathematic rich presence macro values #385

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Nov 14, 2024

Avoids the overhead of creating a value object for macro parameters that are simple mathematic expressions:

@Score(0xH1234*100_0xH1235)

Would create:

AddSource byte 0x1234 * 100
Measured  byte 0x1235

Which would intrinsically have a modified memref chain of "byte 0x1234 * 100 + byte 0x1235". This updates the logic so the macro can reference the chain directly without needing to define the conditions or the condition container.

More complex parameters (i.e. something counting hits or something with a PauseIf) would still need to generate the more complex container.

@Jamiras Jamiras added this to the 11.7.0 milestone Nov 14, 2024
@Jamiras Jamiras merged commit d4386ee into RetroAchievements:develop Dec 5, 2024
7 checks passed
@Jamiras Jamiras deleted the feature/rp_memref_chain branch December 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant