Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 21 achievement sets with rich presence containing memory reads in the form
0x0xADDR
.This currently "works" because the leading
0x
is discardedrcheevos/src/rcheevos/memref.c
Lines 79 to 83 in 6fba22f
Then it does a hex parse of the remaining string
rcheevos/src/rcheevos/memref.c
Line 141 in 6fba22f
which detects and ignores the second
0x
.While this doesn't generate an error in the existing runtime, it does cause issues with some external parsers, and should be reported as an error. This PR causes it to be reported as an error.
The rich presence scripts for the following games should be updated to prevent the error from being reported after this code is published.
There are no occurrences of the pattern in existing achievement or leaderboard definitions.
Also now reporting an error when RP conditionals don't full parse: https://discord.com/channels/310192285306454017/1314383114960633918/1314760614803017778