Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: shutdown fails when ES not running #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tolaris
Copy link

@Tolaris Tolaris commented Nov 26, 2018

This fixes a bug that prevents safe shutdown when EmulationStation is not running.

The os.system() calls use && (logical and) statements, which require each command to return 0 on exit, or the next command won't be run. The "sudo killall emulationstation" fails when ES isn't running, such as when the user has pressed F4 to work at the terminal. Thus the system doesn't shut down. Using simple ";" statements sequences the commands without regard to exit status.

This fixes a bug that prevents safe shutdown when EmulationStation is not running.

The os.system() calls use && (logical and) statements, which require each command to return 0 on exit, or the next command won't be run. The "sudo killall emulationstation" fails when ES isn't running, such as when the user has pressed F4 to work at the terminal. Thus the system doesn't shut down. Using simple ";" statements sequences the commands without regard to exit status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants