Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve web vitals #250

Merged
merged 26 commits into from
Jan 26, 2025
Merged

fix: improve web vitals #250

merged 26 commits into from
Jan 26, 2025

Conversation

Dozie2001
Copy link
Contributor

@Dozie2001 Dozie2001 commented Dec 7, 2024

This PR aims to improve the following web vitals:

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:46pm

Copy link

vercel bot commented Dec 7, 2024

@Dozie2001 is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

@Dozie2001 Dozie2001 marked this pull request as ready for review December 28, 2024 12:06
@rkalis
Copy link
Member

rkalis commented Jan 20, 2025

Ok I took a look at this PR and made some (small) changes:

  • I reverted the .webp changes, as we discussed in Discord, since any images (should) get optimised at runtime by Vercel's image optimsation already
  • I reverted some changes that appeared to not provide any real improvements or add too much complexity
  • Removed the change to the DonateModal since that was messing up the Modal transitions
  • Made some style changes (e.g. default export the new analytics object)

I think we should merge this into master and we can always improve on this down the line. But for now I think there's no low hanging fruit any more that we can tackle to get big improvements.

@rkalis rkalis changed the title Web vitals fix: improve web vitals Jan 26, 2025
@rkalis rkalis merged commit 23ccd34 into RevokeCash:master Jan 26, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants