Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_maps_flutter] fixes to web controller and test file #1

Closed
wants to merge 1 commit into from
Closed

[google_maps_flutter] fixes to web controller and test file #1

wants to merge 1 commit into from

Conversation

LuisReyes98
Copy link

I fixed code issues in running the web integration in the controller and the google_maps_flutter_web/example/integration_test/google_maps_plugin_test.dart file
Also changed the packages/google_maps_flutter/google_maps_flutter/pubspec.yaml to properly run the dev environment for the web version

These fixes were done here so hopefully the main PR flutter#3257 is approved faster

Fixed issues:

  • Code didn't run on web version because of code typos referencing the wrong variable name
  • Fixed an issue in the test of a misplace semicolon
  • Now the web integration boots and runs properly

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Rexios80 pushed a commit that referenced this pull request Mar 19, 2024
@engine-flutter-autoroll
Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter#5104)
bb9de56 
flutter/flutter@f52fe4f...83134ac

2023-10-10 [email protected] Roll Flutter Engine from 2b3f9886fbf0 to 60e861dfe6b1 (1 revision) (flutter/flutter#136264)
2023-10-10 [email protected] Roll Flutter Engine from e354a13cfeab to 2b3f9886fbf0 (4 revisions) (flutter/flutter#136259)
2023-10-10 [email protected] Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter/flutter#136258)
2023-10-10 [email protected] RenderAnnotatedRegion should dispose created layers. (flutter/flutter#136086)
2023-10-10 [email protected] TestClipPaintingContext should dispose ContainerLayer (flutter/flutter#135949)
2023-10-10 [email protected] Roll Flutter Engine from 9aa7cb057d22 to e354a13cfeab (1 revision) (flutter/flutter#136248)
2023-10-10 [email protected] Migrate the "Non-speed related performance issues" issue template to Github forms (flutter/flutter#135130)
2023-10-10 [email protected] Roll Flutter Engine from 171b4b26e68b to 9aa7cb057d22 (4 revisions) (flutter/flutter#136240)
2023-10-10 [email protected] Roll Flutter Engine from d094401acb99 to 171b4b26e68b (1 revision) (flutter/flutter#136235)
2023-10-10 [email protected] Roll Flutter Engine from 92880e9847b3 to d094401acb99 (1 revision) (flutter/flutter#136233)
2023-10-10 [email protected] Roll Flutter Engine from 51193f8f53eb to 92880e9847b3 (1 revision) (flutter/flutter#136232)
2023-10-09 [email protected] Roll Flutter Engine from 8f2fa3ceb8a0 to 51193f8f53eb (4 revisions) (flutter/flutter#136228)
2023-10-09 [email protected] Roll Flutter Engine from 73da593bac54 to 8f2fa3ceb8a0 (2 revisions) (flutter/flutter#136220)
2023-10-09 [email protected] [conductor] Remove PublishChannel and use MPA command (flutter/flutter#135884)
2023-10-09 [email protected] Roll Flutter Engine from 0966f62d7101 to 73da593bac54 (1 revision) (flutter/flutter#136216)
2023-10-09 [email protected] [leak-tracking] Add leak tracking in test/painting #1 (flutter/flutter#136167)
2023-10-09 [email protected] [leak-tracking] Cover testwidgets with leak tracking in test/gestures (flutter/flutter#136166)
2023-10-09 [email protected] Roll Flutter Engine from 81e5bf29dee4 to 0966f62d7101 (1 revision) (flutter/flutter#136215)
2023-10-09 [email protected] Roll Flutter Engine from 22ce5c6a45e2 to 81e5bf29dee4 (3 revisions) (flutter/flutter#136211)
2023-10-09 [email protected] [web] Fix `page up` `page down` `home` `end` shortcut behavior on web (flutter/flutter#135454)
2023-10-09 [email protected] Update `MediaQuery` documentation to highlight asynchronous nature of size (flutter/flutter#135719)
2023-10-09 [email protected] Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rouâ�¦ (flutter/flutter#134554)
2023-10-09 [email protected] Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) (flutter/flutter#136205)
2023-10-09 [email protected] Roll Packages from e578a16 to 7de08ec (4 revisions) (flutter/flutter#136202)
2023-10-09 [email protected] Roll Flutter Engine from 664f5e833871 to 429a242b0db6 (2 revisions) (flutter/flutter#136201)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Rexios80
Copy link
Owner

So sorry I didn't see this until just now. Is this still an issue? I don't think this causes any errors in the PR checks.

@LuisReyes98
Copy link
Author

I just checked the main errors have also been fixed in the original repo, the only change this PR would add is adding the
google_maps_flutter_web to the dependency_overrides in the file
packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

And that is only needed for local testing of the web implementation.
So, this could be merged without problems while this is still in the testing phase.

@Rexios80 Rexios80 closed this Apr 18, 2024
Rexios80 pushed a commit that referenced this pull request Jan 9, 2025
@stuartmorgan
Revert "[shared_preferences] Add shared preferences devtools" (flutte…
7632d2c 
…r#8314)

Reverts flutter#6749

This is failing the publish step:

```
Running 'build_and_copy' in shared_preferences_tool
[build_and_copy] Building the extension Flutter web app...
Could not find an option named "--web-renderer".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
Unhandled exception:
ProcessException: Failed with exit code: 64
  Command: flutter build web --web-renderer canvaskit --pwa-strategy=offline-first --release --no-tree-shake-icons
#0      BuildExtensionCommand._runProcess (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:134:7)
<asynchronous suspension>
#1      BuildExtensionCommand.run (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:57:5)
<asynchronous suspension>
#2      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
flutter#3      SharedStdIn.terminate (package:io/src/shared_stdin.dart:91:3)
<asynchronous suspension>
flutter#4      main (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/devtools_extensions.dart:16:3)
<asynchronous suspension>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: google_maps_flutter platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuisReyes98 @Rexios80