Fix improper slider judgement considerations

Rian8337 · Nov 12, 2024 · 301a286 · 301a286
1 parent d7a1ed2
commit 301a286
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/interactions/commands/osu! and osu!droid/simulate/simulate.ts b/src/interactions/commands/osu! and osu!droid/simulate/simulate.ts
@@ -493,7 +493,9 @@ export const run: SlashCommand["run"] = async (_, interaction) => {
             // Start with slider head first.
             addSliderNestedResult(
                 object.nestedHitObjects[0],
-                Math.abs(hitAccuracy) !== Math.floor(simulatedHitWindow50) + 13,
+                -simulatedHitWindow50 <= hitAccuracy &&
+                    hitAccuracy <=
+                        Math.min(simulatedHitWindow50, object.duration),
             );
 
             // Then, handle the slider ticks and repeats.

diff --git a/src/utils/timingdistribution/TimingDistributionChart.ts b/src/utils/timingdistribution/TimingDistributionChart.ts
@@ -142,7 +142,10 @@ export class TimingDistributionChart {
 
             if (
                 object instanceof Slider &&
-                objectData.accuracy === Math.floor(hitWindow50) + 13
+                !(
+                    -hitWindow50 > objectData.accuracy ||
+                    objectData.accuracy > Math.min(hitWindow50, object.duration)
+                )
             ) {
                 continue;
             }