Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Widget hold an id instead #427

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Sep 22, 2023

No description provided.

@M-Adoo M-Adoo force-pushed the refactor-merge-widget-and-id branch 3 times, most recently from 4d66f96 to 1dec34e Compare September 25, 2023 07:35
@M-Adoo M-Adoo marked this pull request as ready for review September 25, 2023 07:36
@M-Adoo M-Adoo enabled auto-merge September 25, 2023 07:36
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 132 lines in your changes are missing coverage. Please review.

Comparison is base (cfa7faf) 84.44% compared to head (8fce42d) 84.82%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   84.44%   84.82%   +0.38%     
==========================================
  Files         177      172       -5     
  Lines       22241    22054     -187     
==========================================
- Hits        18782    18708      -74     
+ Misses       3459     3346     -113     
Files Coverage Δ
core/src/animation/animate.rs 82.67% <ø> (-0.14%) ⬇️
core/src/builtin_widgets.rs 92.30% <100.00%> (-0.55%) ⬇️
core/src/builtin_widgets/align.rs 93.98% <100.00%> (-0.09%) ⬇️
core/src/builtin_widgets/anchor.rs 96.72% <100.00%> (-0.14%) ⬇️
core/src/builtin_widgets/box_decoration.rs 95.51% <100.00%> (-0.06%) ⬇️
core/src/builtin_widgets/cursor.rs 100.00% <100.00%> (ø)
core/src/builtin_widgets/delay_drop.rs 100.00% <100.00%> (ø)
core/src/builtin_widgets/fitted_box.rs 98.26% <100.00%> (-0.02%) ⬇️
core/src/builtin_widgets/focus_node.rs 93.82% <100.00%> (-2.76%) ⬇️
core/src/builtin_widgets/focus_scope.rs 100.00% <100.00%> (ø)
... and 93 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo force-pushed the refactor-merge-widget-and-id branch from 1dec34e to d8a2fe0 Compare September 25, 2023 12:09
@M-Adoo M-Adoo requested review from sologeek and wjian23 and removed request for sologeek September 26, 2023 03:24
@M-Adoo M-Adoo force-pushed the refactor-merge-widget-and-id branch from d8a2fe0 to 8fce42d Compare September 26, 2023 03:38
@M-Adoo M-Adoo added this pull request to the merge queue Sep 26, 2023
Merged via the queue into master with commit d24d541 Sep 26, 2023
6 checks passed
@M-Adoo M-Adoo deleted the refactor-merge-widget-and-id branch September 26, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants