-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Widget
hold an id instead
#427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Adoo
force-pushed
the
refactor-merge-widget-and-id
branch
3 times, most recently
from
September 25, 2023 07:35
4d66f96
to
1dec34e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 84.44% 84.82% +0.38%
==========================================
Files 177 172 -5
Lines 22241 22054 -187
==========================================
- Hits 18782 18708 -74
+ Misses 3459 3346 -113
☔ View full report in Codecov by Sentry. |
M-Adoo
force-pushed
the
refactor-merge-widget-and-id
branch
from
September 25, 2023 12:09
1dec34e
to
d8a2fe0
Compare
M-Adoo
requested review from
sologeek and
wjian23
and removed request for
sologeek
September 26, 2023 03:24
M-Adoo
force-pushed
the
refactor-merge-widget-and-id
branch
from
September 26, 2023 03:38
d8a2fe0
to
8fce42d
Compare
wjian23
approved these changes
Sep 26, 2023
sologeek
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.