-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/simplify type convert #612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These traits are used to support parent widgets in composing child widgets and allow types to be converted into a child widget.
…ith child widgets. Merge SingleWithChild, MultiWithChild, and ComposeWithChild into a single trait called WithChild. Remove SingleParent and MultiParent traits. Allow only the child to be converted to a widget or a type that implements the Into trait.
github-actions
bot
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 10:20
7faa51b
to
1e14d3b
Compare
M-Adoo
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 10:25
1e14d3b
to
0b349df
Compare
github-actions
bot
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 10:26
0b349df
to
ba8e23d
Compare
M-Adoo
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 10:30
ba8e23d
to
186a071
Compare
github-actions
bot
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 10:30
186a071
to
227723a
Compare
M-Adoo
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 11:33
227723a
to
42f38c2
Compare
github-actions
bot
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 11:33
42f38c2
to
172b97b
Compare
M-Adoo
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 13:44
172b97b
to
0242333
Compare
github-actions
bot
force-pushed
the
refactor/simplify-type-convert
branch
from
August 1, 2024 13:44
0242333
to
194920e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.