-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat provider #618
Merged
Merged
Feat provider #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithin the widget add `WidgetCtx::query`, `WidgetCtx::query_write`, `WidgetCtx::query_of_widget` and `WidgetCtx::query_write_of_widget` Breaking: Removed `WidgetCtx::query_widget_type` and `WidgetCtx::query_type`
github-actions
bot
force-pushed
the
feat-provider
branch
from
August 20, 2024 15:05
4fa2a38
to
895c66b
Compare
github-actions
bot
force-pushed
the
feat-provider
branch
from
August 20, 2024 15:25
5fc5767
to
e4448cd
Compare
github-actions
bot
force-pushed
the
feat-provider
branch
from
August 20, 2024 15:41
cf1379e
to
d5d6e0b
Compare
Removed `FullTheme` and `InheritTheme`, now only using `Theme`.
…ent callbacks BREAKING CHANGE: 🧨 Removed `Overlay::new_with_handle`, `OverlayCloseHandle` and `OverlayStyle`
github-actions
bot
force-pushed
the
feat-provider
branch
from
August 20, 2024 16:10
bda32d0
to
fa73738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
This pull request accomplishes three main objectives:
Provider
widget for data sharing between sub-trees.Provider
to streamline theme management:FullTheme
andInheritTheme
; any component of theTheme
, such asPalette
, can now directly overwrite theTheme
.Overlay
functionality, as overlay querying in event callbacks is now supported.Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.