Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/checkbox #666

Merged
merged 11 commits into from
Dec 2, 2024
Merged

Refactor/checkbox #666

merged 11 commits into from
Dec 2, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Dec 1, 2024

Purpose of this Pull Request

A rollup of commits has been implemented to resolve bugs and refactor the Ripple and Checkbox widgets using the new Class system.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo enabled auto-merge December 1, 2024 02:45
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 92.72370% with 74 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (a7d939d) to head (02e24b1).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
themes/material/src/state_layer.rs 54.09% 28 Missing ⚠️
themes/material/src/ripple.rs 63.38% 26 Missing ⚠️
core/src/builtin_widgets/box_decoration.rs 99.04% 5 Missing ⚠️
core/src/widget_tree/widget_id.rs 16.66% 5 Missing ⚠️
core/src/builtin_widgets/class.rs 96.74% 4 Missing ⚠️
painter/src/painter.rs 0.00% 4 Missing ⚠️
macros/src/lerp_derive.rs 50.00% 1 Missing ⚠️
macros/src/lib.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   83.93%   84.84%   +0.91%     
==========================================
  Files         200      206       +6     
  Lines       26350    27513    +1163     
==========================================
+ Hits        22116    23344    +1228     
+ Misses       4234     4169      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo force-pushed the refactor/checkbox branch from 02e24b1 to 657b681 Compare December 1, 2024 03:33
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Dec 1, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Dec 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/checkbox branch from 768edab to d09714c Compare December 1, 2024 03:59
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels Dec 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/checkbox branch from d09714c to 77327da Compare December 1, 2024 04:12
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels Dec 1, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Dec 2, 2024
Merged via the queue into RibirX:master with commit 8609f1b Dec 2, 2024
15 checks passed
@M-Adoo M-Adoo deleted the refactor/checkbox branch December 2, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants