-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/checkbox #666
Merged
Merged
Refactor/checkbox #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in widgets as intended
…patibility purposes
…he class in `FatObj`
github-actions
bot
force-pushed
the
refactor/checkbox
branch
from
December 1, 2024 02:45
04f8135
to
02e24b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 83.93% 84.84% +0.91%
==========================================
Files 200 206 +6
Lines 26350 27513 +1163
==========================================
+ Hits 22116 23344 +1228
+ Misses 4234 4169 -65 ☔ View full report in Codecov by Sentry. |
M-Adoo
force-pushed
the
refactor/checkbox
branch
from
December 1, 2024 03:33
02e24b1
to
657b681
Compare
github-actions
bot
force-pushed
the
refactor/checkbox
branch
from
December 1, 2024 03:33
657b681
to
768edab
Compare
M-Adoo
force-pushed
the
refactor/checkbox
branch
from
December 1, 2024 03:59
768edab
to
d09714c
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
Dec 1, 2024
Due to potential changes in the ID recorded in the class node.
M-Adoo
force-pushed
the
refactor/checkbox
branch
from
December 1, 2024 04:12
d09714c
to
77327da
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
Dec 1, 2024
wjian23
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
A rollup of commits has been implemented to resolve bugs and refactor the Ripple and Checkbox widgets using the new Class system.
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.