Skip to content

Commit

Permalink
Page details: remove share this page
Browse files Browse the repository at this point in the history
  • Loading branch information
Garneauma committed Jun 3, 2024
1 parent f394b64 commit aab54e0
Show file tree
Hide file tree
Showing 18 changed files with 348 additions and 308 deletions.
201 changes: 112 additions & 89 deletions _data/sites.json
Original file line number Diff line number Diff line change
Expand Up @@ -2348,8 +2348,8 @@
"en": "Documentation on how to use the page details section.",
"fr": "Documentation sur l'utilisation de la section des détails de la page."
},
"version": "3.0",
"modified": "2022-04-11",
"version": "4.0",
"modified": "2024-06-03",
"componentName": "page-details",
"componentType": "container",
"status": "stable",
Expand Down Expand Up @@ -2386,26 +2386,6 @@
"title": "Détails de la page avec Outil de rétroaction sur la page",
"language": "fr",
"path": "page-details-pft-fr.html"
},
{
"title": "Page details with Share this page",
"language": "en",
"path": "page-details-share-en.html"
},
{
"title": "Détails de la page avec Partagez cette page",
"language": "fr",
"path": "page-details-share-fr.html"
},
{
"title": "Page details with Page feedback tool and Share this page",
"language": "en",
"path": "page-details-pft-share-en.html"
},
{
"title": "Détails de la page avec Outil de rétroaction sur la page et Partagez cette page",
"language": "fr",
"path": "page-details-pft-share-fr.html"
}
],
"reports": [
Expand Down Expand Up @@ -2434,12 +2414,10 @@
"dependencies": {
"en": [
{ "title": "Feedback area", "url": "https://wet-boew.github.io/GCWeb/sites/feedback/feedback-docs-en.html", "component": "feedback" },
{ "title": "Share widget", "url": "https://wet-boew.github.io/wet-boew/docs/ref/share/share-en.html", "component": "share" },
{ "title": "Date modified", "url": "https://wet-boew.github.io/GCWeb/sites/date-modified/date-modified-en.html", "component": "date-modified" }
],
"fr": [
{ "title": "Zone de rétroaction", "url": "https://wet-boew.github.io/GCWeb/sites/feedback/feedback-docs-fr.html", "component": "feedback" },
{ "title": "Gadget de partage", "url": "https://wet-boew.github.io/wet-boew/docs/ref/share/share-fr.html", "component": "share" },
{ "title": "Date de modification", "url": "https://wet-boew.github.io/GCWeb/sites/date-modified/date-modified-fr.html", "component": "date-modified" }
]
},
Expand All @@ -2452,8 +2430,8 @@
},
"status": "stable",
"description": {
"en": "This component may contain the following components: Page feedback tool, Share this page, and Date modified.",
"fr": "Ce composant peut contenir les composants suivants : Outil de rétroaction sur la page, Partager cette page et Date de modification."
"en": "This component may contain the following components: Page feedback tool and Date modified.",
"fr": "Ce composant peut contenir les composants suivants : Outil de rétroaction sur la page et Date de modification."
},
"iteration": "_:iteration_pd_3",
"example": [
Expand All @@ -2464,21 +2442,17 @@
{
"en": { "href": "page-details-pft-en.html", "text": "Page details with Page feedback tool" },
"fr": { "href": "page-details-pft-fr.html", "text": "Détails de la page avec Outil de rétroaction sur la page" }
},
{
"en": { "href": "page-details-share-en.html", "text": "Page details with Share this page" },
"fr": { "href": "page-details-share-fr.html", "text": "Détails de la page avec Partagez cette page" }
},
{
"en": { "href": "page-details-pft-share-en.html", "text": "Page details with Page feedback tool and Share this page" },
"fr": { "href": "page-details-pft-share-fr.html", "text": "Détails de la page avec Outil de rétroaction sur la page et Partagez cette page" }
}
],
"implementation": [
"_:implement_pd",
"_:implement_pd_gcweb"
],
"history": [
{
"en": "June 2024 - Removed \"Share this page\" option.",
"fr": "Juin 2024 - Retrait de l'option « Partagez cette page »."
},
{
"en": "March 2023 - Tag <footer> changed to <section>.",
"fr": "Mars 2023 - Balise <footer> changée pour <section>."
Expand Down Expand Up @@ -2508,22 +2482,20 @@
},
"instructions": {
"en": [
"The Page details component must include the Date modified component. It can also contain the Page feedback component and the Share this page widget. See below the code sample for each scenario.",
"For more information about Page feedback tool component, please visit <a href=\"../sites/feedback/page-feedback-docs-en.html\">Page feedback area</a> page.",
"For more information about Share widget plugin, please visit <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/share/share-en.html\">Share widget page</a>."
"The Page details component must include the Date modified component. It can also contain the Page feedback component. See below the code sample for each scenario.",
"For more information about Page feedback tool component, please visit <a href=\"../sites/feedback/page-feedback-docs-en.html\">Page feedback area</a> page."
],
"fr": [
"Le composant Détails de la page doit inclure le composant Date de modification. Il peut également contenir le composant Outil de rétroaction sur la page et le widget Partager cette page. Voir ci-dessous l'exemple de code pour chaque scénario.",
"Pour plus d'informations sur le composant de l'Outil de rétroaction sur la page, veuillez visiter la page <a href=\"../sites/feedback/page-feedback-docs-fr.html\">Zone de rétroaction sur la page</a>.",
"Pour plus d'informations sur le plugin de partage de widget, veuillez visiter la <a href=\"https://wet-boew.github.io/wet-boew/docs/ref/share/share-fr.html\">page de partage de widget </a>."
"Le composant Détails de la page doit inclure le composant Date de modification. Il peut également contenir le composant Outil de rétroaction sur la page. Voir ci-dessous l'exemple de code pour chaque scénario.",
"Pour plus d'informations sur le composant de l'Outil de rétroaction sur la page, veuillez visiter la page <a href=\"../sites/feedback/page-feedback-docs-fr.html\">Zone de rétroaction sur la page</a>."
]
},
"notes": {
"en": [
"Although the component has been updated to version 3.0, the version 2.0 is still supported. However, the page content and the &lt;footer&gt; have to be located inside an &lt;article&gt; tag."
"Although the component has been updated to version 4.0, the version 2.0 and 3.0 are still supported. However, the page content and the &lt;footer&gt; have to be located inside an &lt;article&gt; tag."
],
"fr": [
"Bien que le composant ait été mis à jour vers la version 3.0, la version 2.0 est toujours prise en charge. Cependant, le contenu de la page et le &lt;footer&gt; doivent être situés à l'intérieur d'une balise &lt;article&gt;."
"Bien que le composant ait été mis à jour vers la version 4.0, la version 2.0 and 3.0 sont toujours pris en charge. Cependant, le contenu de la page et le &lt;footer&gt; doivent être situés à l'intérieur d'une balise &lt;article&gt;."
]
},
"sample": {
Expand All @@ -2533,32 +2505,15 @@
"description": "Default Page details:",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-en.html#default"
"@value": "samples/page-details-4-en.html#default"
}
},
{
"@type": "source-code",
"description": "Page details with Page feedback tool:",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-en.html#pft"
}
},
{
"@type": "source-code",
"description": "Page details with Share this page:",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-en.html#share"
}
}
,
{
"@type": "source-code",
"description": "Page details with Page feedback tool and Share this page:",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-en.html#pftShare"
"@value": "samples/page-details-4-en.html#pft"
}
}
],
Expand All @@ -2568,32 +2523,15 @@
"description": "Détails de la page par défaut :",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-fr.html#default"
"@value": "samples/page-details-4-fr.html#default"
}
},
{
"@type": "source-code",
"description": "Détails de la page avec Outil de rétroaction sur la page :",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-fr.html#pft"
}
},
{
"@type": "source-code",
"description": "Détails de la page avec Partagez cette page :",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-fr.html#share"
}
}
,
{
"@type": "source-code",
"description": "Détails de la page avec Outil de rétroaction sur la page et Partagez cette page :",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "samples/page-details-3-fr.html#pftShare"
"@value": "samples/page-details-4-fr.html#pft"
}
}
]
Expand All @@ -2612,27 +2550,25 @@
},
"instructions": {
"en": [
"To show the \"Page feedback tool\", in the page's front-matter, set the property <code>feedback</code> to <code>true</code>.",
"To show the \"Share this page\" button, in the page's front-matter, set the property <code>share</code> to <code>true</code>."
"To show the \"Page feedback tool\", in the page's front-matter, set the property <code>feedback</code> to <code>true</code>."
],
"fr": [
"Pour afficher l'\"Outil de rétroaction sur la page\", dans l'en-tête de la page, définissez la propriété <code>feedback</code> à <code>true</code>.",
"Pour afficher le bouton \"Partagez cette page\", dans l'en-tête de la page, définissez la propriété <code>share</code> à <code>true</code>."
"Pour afficher l'\"Outil de rétroaction sur la page\", dans l'en-tête de la page, définissez la propriété <code>feedback</code> à <code>true</code>."
]
},
"sample": {
"en": [
{
"@type": "source-code",
"description": "Code sample:",
"code": "\"feedback\": true, \n\"share\": true"
"code": "\"feedback\": true"
}
],
"fr": [
{
"@type": "source-code",
"description": "Exemple de code:",
"code": "\"feedback\": true, \n\"share\": true"
"code": "\"feedback\": true"
}
]
}
Expand All @@ -2650,10 +2586,10 @@
},
"instructions": {
"en": [
"Although the Page details component has been updated to version 3.0, the version 2.0 is still supported. However, the page content and the <code>&lt;footer&gt;</code> have to be located inside an <code>&lt;article&gt;</code> tag."
"Although the Page details component has been updated to version 4.0, the version 2.0 and 3.0 are still supported. However, the page content and the <code>&lt;footer&gt;</code> have to be located inside an <code>&lt;article&gt;</code> tag."
],
"fr": [
"Bien que le composant Détails de la page ait été mis à jour vers la version 3.0, la version 2.0 est toujours prise en charge. Cependant, le contenu de la page et le <code>&lt;footer&gt;</code>. doivent être situés à l'intérieur d'une balise <code>&lt;article&gt;</code>."
"Bien que le composant Détails de la page ait été mis à jour vers la version 4.0, la version 2.0 et 3.0 sont toujours pris en charge. Cependant, le contenu de la page et le <code>&lt;footer&gt;</code>. doivent être situés à l'intérieur d'une balise <code>&lt;article&gt;</code>."
]
},
"notes": {
Expand Down Expand Up @@ -2689,12 +2625,61 @@
}
],
"iteration": [
{
"@id": "_:iteration_pd_4",
"name": "Page details - Iteration 4",
"date": "2024-06",
"detectableBy": "section.pagedetails",
"predecessor": "_:iteration_pd_3",
"fixes": [
"Removed \"Share this page\" button option."
],
"assets": [
{
"@type": "source-code",
"@language": "en",
"description": "Default Page details",
"code": {
"@type": [ "rdf:HTML", "@id" ],
"@value": "samples/page-details-4-en.html#default"
}
},
{
"@type": "source-code",
"@language": "fr",
"description": "Détails de la page par défaut",
"code": {
"@type": [ "rdf:HTML", "@id" ],
"@value": "samples/page-details-4-fr.html#default"
}
},
{
"@type": "source-code",
"@language": "en",
"description": "Page details with Page feedback tool",
"code": {
"@type": [ "rdf:HTML", "@id" ],
"@value": "samples/page-details-4-en.html#pft"
}
},
{
"@type": "source-code",
"@language": "fr",
"description": "Détails de la page avec Outil de rétroaction sur la page",
"code": {
"@type": [ "rdf:HTML", "@id" ],
"@value": "samples/page-details-4-fr.html#pft"
}
}
]
},
{
"@id": "_:iteration_pd_3",
"name": "Page details - Iteration 3",
"date": "2023-03",
"detectableBy": "section.pagedetails",
"predecessor": "_:iteration_pd_2",
"successor": "_:iteration_pd_3",
"fixes": [
"Changed <footer> to <section> as <footer> element does not provide a semantic break."
],
Expand Down Expand Up @@ -2838,6 +2823,44 @@
}
],
"changesets": [
{
"@id": "_:cs_pd_4",
"name": "Page details - version 4.0",
"status": "stable",
"baseOnIteration": "_:iteration_pd_4",
"detectableBy": "section.pagedetails",
"layout": [
"Page feedback tool (if included) on the top left",
"Date modified on bottom left"
],
"style": "Not applicable",
"semantic": {
"@type": "source-code",
"description": "Source code",
"code": "<section class=\"pagedetails\">\n\t<h2>[i18nText-pageDetails]</h2>\n\t<!-- Page feedback tool (optional) -->\n\t<!-- Date modified (mandatatory) -->\n</section>"
},
"include": {
"@type": "source-code",
"collapsed": true,
"description": "Include with logic in Liquid.",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "includes/footer.html"
}
},
"logic": "Not applicable",
"guidance": "Not applicable",
"context": "Not applicable",
"configuration": [
"Input the date when the page was last modified inside the <time> tag in the format YYYY-MM-DD."
],
"static": [
"Section header: \"Page details\""
],
"schema": "Not applicable",
"dependency": "Not applicable",
"file": "Not applicable"
},
{
"@id": "_:cs_pd_3",
"name": "Page details - Compatible with PFT + Accessiblity fix (version 3.0)",
Expand All @@ -2861,7 +2884,7 @@
"description": "Include with logic in Liquid.",
"code": {
"@type": [ "@id", "rdf:HTML" ],
"@value": "includes/footer.html"
"@value": "includes/footer-3.0.html"
}
},
"logic": "Not applicable",
Expand Down
20 changes: 20 additions & 0 deletions _includes/sites/page-details/page-details-4-en.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- Default Page details -->
<div id="default">
<section class="pagedetails">
<h2 class="wb-inv">Page details</h2>
[Date modified component]
</section>
</div>

<!-- Page details with Page feedback tool -->
<div id="pft">
<section class="pagedetails">
<h2 class="wb-inv">Page details</h2>
<div class="row">
<div class="col-sm-8 col-md-9 col-lg-9">
[Page feedback tool component version 2.0 or newer]
</div>
</div>
[Date modified component]
</section>
</div>
20 changes: 20 additions & 0 deletions _includes/sites/page-details/page-details-4-fr.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- Default Détails de la page -->
<div id="default">
<section class="pagedetails">
<h2 class="wb-inv">Détails de la page</h2>
[Composant Date de modification]
</section>
</div>

<!-- Détails de la page with Page feedback tool -->
<div id="pft">
<section class="pagedetails">
<h2 class="wb-inv">Détails de la page</h2>
<div class="row">
<div class="col-sm-8 col-md-9 col-lg-9">
[Composant Outil de rétroaction sur la page version 2.0 ou plus récente]
</div>
</div>
[Composant Date de modification]
</section>
</div>
Loading

0 comments on commit aab54e0

Please sign in to comment.